feat(deployment-rules): implement create, edit, and index routes for deployment rules#2474
feat(deployment-rules): implement create, edit, and index routes for deployment rules#2474TheoGrandin74 wants to merge 2 commits intonew-navigationfrom
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2474 +/- ##
=================================================
Coverage ? 43.34%
=================================================
Files ? 686
Lines ? 15528
Branches ? 4535
=================================================
Hits ? 6731
Misses ? 7587
Partials ? 1210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks @TheoGrandin74, here my small feedback:
- You don't have the same container between the list and the edit, you probably have an padding inside the edit
- (optional) could you add the props alignement top for this toggle?
| }) | ||
|
|
||
| function RouteComponent() { | ||
| return <EditDeploymentRule /> |
There was a problem hiding this comment.
I think you need to add the page title inside this view
| }) | ||
|
|
||
| function RouteComponent() { | ||
| return <CreateDeploymentRule /> |
There was a problem hiding this comment.
Same here, missing a page title
| }) | ||
|
|
||
| function RouteComponent() { | ||
| return <DeploymentRules /> |
There was a problem hiding this comment.
Same here, missing a page title
| : {} | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
You can remove this Fragment <>
| } | ||
|
|
||
| export function PageCreateEditDeploymentRule(props: PageCreateEditDeploymentRuleProps) { | ||
| export function CreateEditDeploymentRule(props: CreateEditDeploymentRuleProps) { |
There was a problem hiding this comment.
Could you add in this component a loading state for the button when you submit the form? 🙏
2 participants
Summary
Empty state
List
Create/edit
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release