Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
…CheckCustomDomains hooks
|
View your CI Pipeline Execution ↗ for commit fcb2c6b ☁️ Nx Cloud last updated this comment at |
1 similar comment
|
View your CI Pipeline Execution ↗ for commit fcb2c6b ☁️ Nx Cloud last updated this comment at |
…ding states - Updated useCustomDomains hook to set default suspense to false. - Renamed DomainSettingsFallback to DomainSettingsContentFallback for clarity. - Enhanced ServiceDomainSettings component with loading states and modal handling for custom domains. - Refactored ServiceDomainSettingsContent to accept props for better modularity and removed unnecessary suspense handling.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2473 +/- ##
=================================================
Coverage ? 41.52%
=================================================
Files ? 33
Lines ? 749
Branches ? 233
=================================================
Hits ? 311
Misses ? 358
Partials ? 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| isFetching: isFetchingCheckedCustomDomains, | ||
| } = useCheckCustomDomains({ | ||
| serviceId, | ||
| serviceType: service?.serviceType ?? 'APPLICATION', |
There was a problem hiding this comment.
I can't add suspense because the 400 error status is needed to display the fallback
Summary
Screenshots / Recordings
https://www.loom.com/share/9f72da07fc834eb99d5bc52d13e64576
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release