Skip to content

feat(domain-settings): add view#2473

Open
RemiBonnet wants to merge 6 commits intonew-navigationfrom
feat/new-nav/domain-settings
Open

feat(domain-settings): add view#2473
RemiBonnet wants to merge 6 commits intonew-navigationfrom
feat/new-nav/domain-settings

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Mar 13, 2026

Summary

  • View domain for Helm, Container & Application

Screenshots / Recordings

https://www.loom.com/share/9f72da07fc834eb99d5bc52d13e64576

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

The backlog never ends, be at peace with it

@nx-cloud
Copy link

nx-cloud bot commented Mar 13, 2026

View your CI Pipeline Execution ↗ for commit fcb2c6b


☁️ Nx Cloud last updated this comment at 2026-03-13 14:21:47 UTC

1 similar comment
@nx-cloud
Copy link

nx-cloud bot commented Mar 13, 2026

View your CI Pipeline Execution ↗ for commit fcb2c6b


☁️ Nx Cloud last updated this comment at 2026-03-13 14:21:47 UTC

…ding states

- Updated useCustomDomains hook to set default suspense to false.
- Renamed DomainSettingsFallback to DomainSettingsContentFallback for clarity.
- Enhanced ServiceDomainSettings component with loading states and modal handling for custom domains.
- Refactored ServiceDomainSettingsContent to accept props for better modularity and removed unnecessary suspense handling.
@RemiBonnet RemiBonnet added the V5 label Mar 13, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review March 13, 2026 14:35
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 78.75000% with 17 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@e7ade77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ervice-domain-settings/service-domain-settings.tsx 72.72% 6 Missing and 6 partials ⚠️
...ce-domain-crud-modal/service-domain-crud-modal.tsx 86.11% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2473   +/-   ##
=================================================
  Coverage                  ?   41.52%           
=================================================
  Files                     ?       33           
  Lines                     ?      749           
  Branches                  ?      233           
=================================================
  Hits                      ?      311           
  Misses                    ?      358           
  Partials                  ?       80           
Flag Coverage Δ
unittests 41.52% <78.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

isFetching: isFetchingCheckedCustomDomains,
} = useCheckCustomDomains({
serviceId,
serviceType: service?.serviceType ?? 'APPLICATION',
Copy link
Member Author

@RemiBonnet RemiBonnet Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't add suspense because the 400 error status is needed to display the fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant