Skip to content

feat(service-actions): remove edit code action and add cloud shell to…#2472

Draft
rmnbrd wants to merge 1 commit intonew-navigationfrom
cursor/action-buttons-new-nav
Draft

feat(service-actions): remove edit code action and add cloud shell to…#2472
rmnbrd wants to merge 1 commit intonew-navigationfrom
cursor/action-buttons-new-nav

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Mar 13, 2026

… service overview

  • Remove 'Edit code' action from service actions menu per feedback
  • Add cloud shell action to service overview header
  • Update ServiceHeader and ServiceOverview to support shellAction prop
  • Add ServiceTerminalProvider to service overview route
  • Update test snapshots for removed edit code action

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

… service overview

- Remove 'Edit code' action from service actions menu per feedback
- Add cloud shell action to service overview header
- Update ServiceHeader and ServiceOverview to support shellAction prop
- Add ServiceTerminalProvider to service overview route
- Update test snapshots for removed edit code action

Co-authored-by: Romain Billard <rmnbrd@users.noreply.github.com>
@rmnbrd rmnbrd added the V5 label Mar 13, 2026
@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@e7ade77). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2472   +/-   ##
=================================================
  Coverage                  ?   43.00%           
=================================================
  Files                     ?      584           
  Lines                     ?    13241           
  Branches                  ?     3837           
=================================================
  Hits                      ?     5694           
  Misses                    ?     6542           
  Partials                  ?     1005           
Flag Coverage Δ
unittests 43.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants