Skip to content

feat(database-creation-flow): add flow#2471

Open
RemiBonnet wants to merge 10 commits intonew-navigationfrom
feat/new-nav/databases-creation-flow
Open

feat(database-creation-flow): add flow#2471
RemiBonnet wants to merge 10 commits intonew-navigationfrom
feat/new-nav/databases-creation-flow

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Mar 13, 2026

Summary

  • Added creation flow for Database
  • Removed deprecated files for @pages

Screenshots / Recordings

https://www.loom.com/share/5fe108a880814096a44fe3666b4f5f64

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There are two hard problems in computer science: naming things, cache invalidation and off-by-1 errors

@RemiBonnet RemiBonnet marked this pull request as ready for review March 13, 2026 08:24
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 60.56338% with 84 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@e7ade77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...eation-flow/database/step-general/step-general.tsx 51.06% 8 Missing and 15 partials ⚠️
...se/database-create-utils/database-create-utils.tsx 69.23% 7 Missing and 9 partials ⚠️
...se/database-summary-view/database-summary-view.tsx 41.17% 6 Missing and 4 partials ⚠️
...on-flow/database/step-resources/step-resources.tsx 68.96% 1 Missing and 8 partials ⚠️
...eation-flow/database/step-summary/step-summary.tsx 73.33% 5 Missing and 3 partials ⚠️
...rvices/feature/src/lib/service-new/service-new.tsx 46.66% 2 Missing and 6 partials ⚠️
...-creation-flow/database/database-creation-flow.tsx 65.00% 4 Missing and 3 partials ⚠️
...ib/router-types/service-container-create-params.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2471   +/-   ##
=================================================
  Coverage                  ?   43.21%           
=================================================
  Files                     ?      598           
  Lines                     ?    13779           
  Branches                  ?     4023           
=================================================
  Hits                      ?     5954           
  Misses                    ?     6739           
  Partials                  ?     1086           
Flag Coverage Δ
unittests 43.21% <60.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const generalValues = generalForm.getValues()
const databaseType = generalValues.type ?? 'POSTGRESQL'

const { data: environment } = useEnvironment({ environmentId })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add suspense here? 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! e06fb17

@RemiBonnet RemiBonnet added the V5 label Mar 13, 2026
@RemiBonnet RemiBonnet requested a review from rmnbrd March 13, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants