Skip to content

Stabilize PyTC v2 runtime and dual-schema config flows #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akgohain merged 2 commits into from
Mar 16, 2026
Merged

Stabilize PyTC v2 runtime and dual-schema config flows #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad52f8
feat: stabilize PyTC v2 runtime and config flows
akgohain Mar 16, 2026
0487b0a
chore: make local startup output more graceful
akgohain Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 79 additions & 49 deletions client/src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import axios from "axios";
import { message } from "antd";
import yaml from "js-yaml";
import {
setInferenceExecutionDefaults,
setInferenceOutputPath,
setTrainingOutputPath,
} from "./configSchema";

const BASE_URL = `${process.env.REACT_APP_SERVER_PROTOCOL || "http"}://${process.env.REACT_APP_SERVER_URL || "localhost:4242"}`;

Expand All @@ -22,6 +28,30 @@ const buildFilePath = (file) => {

const hasBrowserFile = (file) => file && file.originFileObj instanceof File;

const getErrorDetailMessage = (detail) => {
if (!detail) return "";
if (typeof detail === "string") return detail;
if (Array.isArray(detail)) {
return detail.map(getErrorDetailMessage).filter(Boolean).join("; ");
}
if (typeof detail === "object") {
const nestedUpstream =
detail.upstream_body !== undefined
? getErrorDetailMessage(detail.upstream_body)
: "";
return [
detail.message,
detail.detail,
detail.reason,
nestedUpstream,
detail.error,
]
.filter(Boolean)
.join(" | ");
}
return String(detail);
};

export async function getNeuroglancerViewer(image, label, scales) {
try {
const url = `${BASE_URL}/neuroglancer`;
Expand Down Expand Up @@ -76,7 +106,7 @@ export async function checkFile(file) {
function handleError(error) {
if (error.response) {
const detail = error.response.data?.detail;
const detailMessage = typeof detail === "string" ? detail : detail?.data;
const detailMessage = getErrorDetailMessage(detail);
throw new Error(
`${error.response.status}: ${detailMessage || error.response.statusText}`,
);
Expand Down Expand Up @@ -106,7 +136,12 @@ export async function makeApiRequest(url, method, data = null) {
}
}

export async function startModelTraining(trainingConfig, logPath, outputPath) {
export async function startModelTraining(
trainingConfig,
logPath,
outputPath,
configOriginPath = "",
) {
try {
console.log("[API] ===== Starting Training Configuration =====");
console.log("[API] logPath:", logPath);
Expand All @@ -115,26 +150,13 @@ export async function startModelTraining(trainingConfig, logPath, outputPath) {
// Parse the YAML config and inject the outputPath
let configToSend = trainingConfig;

if (outputPath) {
if (outputPath && trainingConfig) {
try {
// Parse YAML to object
const yaml = require("js-yaml");
const configObj = yaml.load(trainingConfig);

console.log(
"[API] Original DATASET.OUTPUT_PATH:",
configObj.DATASET?.OUTPUT_PATH,
);
const configObj = yaml.load(trainingConfig) || {};
setTrainingOutputPath(configObj, outputPath);

// Inject the output path from UI
if (!configObj.DATASET) {
configObj.DATASET = {};
}
configObj.DATASET.OUTPUT_PATH = outputPath;

// Convert back to YAML
configToSend = yaml.dump(configObj);
console.log("[API] Injected DATASET.OUTPUT_PATH:", outputPath);
console.log("[API] Injected training output path:", outputPath);
console.log(
"[API] Modified config preview:",
configToSend.substring(0, 500),
Expand All @@ -155,6 +177,7 @@ export async function startModelTraining(trainingConfig, logPath, outputPath) {
logPath, // Keep for backwards compatibility, but won't be used for TensorBoard
outputPath, // TensorBoard will use this instead
trainingConfig: configToSend,
configOriginPath,
});

console.log("[API] Request payload size:", data.length, "bytes");
Expand All @@ -180,19 +203,35 @@ export async function getTrainingStatus() {
const res = await axios.get(`${BASE_URL}/training_status`);
return res.data;
} catch (error) {
console.error("Failed to get training status:", error);
return { isRunning: false, error: true };
handleError(error);
}
}

export async function getTrainingLogs() {
try {
const res = await axios.get(`${BASE_URL}/training_logs`);
return res.data;
} catch (error) {
handleError(error);
}
}

export async function getTensorboardURL() {
return makeApiRequest("get_tensorboard_url", "get");
}

export async function startTensorboard(logPath) {
const query = logPath
? `?${new URLSearchParams({ logPath }).toString()}`
: "";
return makeApiRequest(`start_tensorboard${query}`, "get");
}

export async function startModelInference(
inferenceConfig,
outputPath,
checkpointPath,
configOriginPath = "",
) {
console.log("\n========== API.JS: START_MODEL_INFERENCE CALLED ==========");
console.log("[API] Function arguments:");
Expand All @@ -212,36 +251,18 @@ export async function startModelInference(
// Parse the YAML config and inject the outputPath
let configToSend = inferenceConfig;

if (outputPath) {
console.log("[API] outputPath provided, will inject into YAML");
if (inferenceConfig) {
try {
// Parse YAML to object
const yaml = require("js-yaml");
console.log("[API] Parsing YAML config...");
const configObj = yaml.load(inferenceConfig);
const configObj = yaml.load(inferenceConfig) || {};
console.log("[API] ✓ YAML parsed successfully");

console.log("[API] Original config structure:");
console.log("[API] - Has INFERENCE section?", !!configObj.INFERENCE);
console.log(
"[API] - Original INFERENCE.OUTPUT_PATH:",
configObj.INFERENCE?.OUTPUT_PATH,
);

// Inject the output path from UI
if (!configObj.INFERENCE) {
console.log("[API] INFERENCE section missing, creating it");
configObj.INFERENCE = {};
}
configObj.INFERENCE.OUTPUT_PATH = outputPath;
// Ensure SYSTEM section exists and set NUM_GPUS to 1 for CPU inference
if (!configObj.SYSTEM) {
console.log("[API] SYSTEM section missing, creating it");
configObj.SYSTEM = {};
if (outputPath) {
setInferenceOutputPath(configObj, outputPath);
console.log("[API] ✓ Injected inference output path:", outputPath);
}
configObj.SYSTEM.NUM_GPUS = 1;
console.log("[API] ✓ Set SYSTEM.NUM_GPUS = 1");
console.log("[API] ✓ Injected INFERENCE.OUTPUT_PATH:", outputPath);
setInferenceExecutionDefaults(configObj);
console.log("[API] ✓ Applied inference runtime defaults");

// Convert back to YAML
console.log("[API] Converting back to YAML...");
Expand All @@ -260,7 +281,7 @@ export async function startModelInference(
}
} else {
console.warn(
"[API] ⚠ No outputPath provided, config will use its original OUTPUT_PATH",
"[API] ⚠ No inferenceConfig provided, request will use raw payload value",
);
}

Expand All @@ -271,6 +292,7 @@ export async function startModelInference(
},
outputPath,
inferenceConfig: configToSend,
configOriginPath,
};

console.log("[API] Payload structure:");
Expand Down Expand Up @@ -318,8 +340,16 @@ export async function getInferenceStatus() {
const res = await axios.get(`${BASE_URL}/inference_status`);
return res.data;
} catch (error) {
console.error("Failed to get inference status:", error);
return { isRunning: false, error: true };
handleError(error);
}
}

export async function getInferenceLogs() {
try {
const res = await axios.get(`${BASE_URL}/inference_logs`);
return res.data;
} catch (error) {
handleError(error);
}
}

Expand Down
11 changes: 4 additions & 7 deletions client/src/components/Configurator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ function Configurator(props) {
if (!getPathValue(context.inputImage)) missing.push("input image");
if (!getPathValue(context.inputLabel)) missing.push("input label");
if (!getPathValue(context.outputPath)) missing.push("output path");
if (type === "training" && !getPathValue(context.logPath)) {
missing.push("log path");
}
if (type === "inference" && !getPathValue(context.checkpointPath)) {
missing.push("checkpoint path");
}
Expand All @@ -62,7 +59,6 @@ function Configurator(props) {
context.inputImage,
context.inputLabel,
context.outputPath,
context.logPath,
context.checkpointPath,
type,
]);
Expand All @@ -72,9 +68,10 @@ function Configurator(props) {
? Boolean(context.trainingConfig)
: Boolean(context.inferenceConfig);

const missingBase = hasConfig
? []
: ["base configuration (preset or upload)"];
const missingBase = useMemo(
() => (hasConfig ? [] : ["base configuration (preset or upload)"]),
[hasConfig],
);

const missingByStep = useMemo(() => {
if (current === 0) return missingInputs;
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/InputSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ function InputSelector(props) {
placeholder="Model checkpoint file (e.g., /path/to/checkpoint_00010.pth.tar)"
value={context.checkpointPath || ""}
onChange={handleCheckpointPathChange}
selectionType="directory"
selectionType="file"
/>
</Form.Item>
)}
Expand Down
Loading
Loading