chore: Create module for v1 request encoding#413
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Jul 15, 2025
Merged
chore: Create module for v1 request encoding#413allenporter merged 3 commits intoPython-roborock:mainfrom
allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
Lash-L
previously approved these changes
Jul 14, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
looks good, primarily just moving things so not much to say
allenporter
commented
Jul 14, 2025
| params: list | dict | int | None = None, | ||
| ): | ||
| roborock_message = self.build_roborock_message(method, params) | ||
| if method in CLOUD_REQUIRED: |
Contributor
Author
There was a problem hiding this comment.
This is now a breaking change to just hard fail when trying to do this.
Lash-L
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the v1 request encoding into a separate module that will be shared with the new device library.