fix: remove internal use of deprecated role type methods

[Revnoplex]

Caution

Feature freeze is active, as described by our Release Schedule.

Summary

#2708 deprecated the use of certain role type methods (eg. Role.is_premium_subscriber) in favour of the RoleType enum. Now I found the library throwing several deprecation warnings when firing the on_guild_update event and upon tracing the lines the warnings were emitted from found several uses of the old methods. This pr replaces the found internal usage of these old methods.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.
• AI Usage has been disclosed.
  • If AI has been used, I understand fully what the code does

[pycord-app]

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3167/head:pr-3167
git checkout pr-3167

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3167/head

[Paillat-dev]

My fault...

[Revnoplex]

I'm assuming I need a changelog entry this time as theres an entry for 2.8.0rc1 and the problem was introduced before this

[Soheab]

Should use is when comparing enums.

[Paillat-dev]

Yes needs a changelog as well.

Also please hold till I take a better look

[Paillat-dev]

This one and the next 4 can use self.type instead of self.tags.type. Removes the need for an is not None check too.

Or alternatively use self.tags.method.__wrapped__() which would ensure the actual deprecated tags method is called to have truly the same code run as before deprecation.

[Revnoplex]

how would I use self.tags.method.__wrapped__()?

[Paillat-dev]

For example in this case it would be

        return self.tags is not None and self.tags.is_bot_managed.__wrapped__()        

But I am not sure we wanna do this. Waiting to see what the others think

[Revnoplex]

I mean return self.type is RoleType.TYPE does look cleaner

[Paillat-dev]

The point is that if for some reason self.type is broken / incorrect, the "old deprecated" implementation would not break without notice. Extra safety.

[Revnoplex]

So I should wait for this to be reviewed

[Revnoplex]

wdym hold changelog, I added it. Unless I need to modify it or add another entry

[Paillat-dev]

wdym hold changelog, I added it. Unless I need to modify it or add another entry

Didn't refresh on my end