docs: improve docstring wording for display properties#3163
Closed
Sim-hu wants to merge 1 commit intoPycord-Development:masterfrom
Closed
docs: improve docstring wording for display properties#3163Sim-hu wants to merge 1 commit intoPycord-Development:masterfrom
Sim-hu wants to merge 1 commit intoPycord-Development:masterfrom
Conversation
…nd display_avatar_decoration Replace awkward "for regular members/users" phrasing with clearer descriptions of the guild-specific fallback behavior. Closes #3117
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3163/head:pr-3163
git checkout pr-3163This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3163/head |
Paillat-dev
requested changes
Mar 21, 2026
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
- This is a redo of #3120. Please see the comments there.
- Please follow the pull request template and disclose LLM Usage.
Author
|
Sorry about that, I missed the PR template and didn't realize #3120 was already working on this. Closing in favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the awkward "for regular members" / "for regular users" phrasing in
display_avatar,display_avatar_decoration,display_banner(inMember),and
display_avatar(inUser) with clearer descriptions of theguild-specific fallback behavior.
The original wording ("for regular members this is just their avatar, but...")
reads a bit oddly and implies the existence of "irregular" members. The updated
docstrings now directly describe what the property returns depending on whether
a guild-specific override is set.
Closes #3117