fix: GuildSchedule not being cached correctly + missing fields by Lumabots · Pull Request #3025 · Pycord-Development/pycord

Lumabots · 2025-12-09T19:51:26Z

Summary

summary is not complete, just check the code

Added
New Enums :
ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily)
ScheduledEventRecurrenceWeekday (monday-sunday)
ScheduledEventRecurrenceMonth (january-december)

New Classes:
ScheduledEventEntityMetadata (location)
ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday")
ScheduledEventRecurrenceRule: Full recurrence rule with validation

Auto-validates on to_payload() serialization
New fields Guild.create_scheduled_event():

well at this point just read the code

Enforces Discord's constraints:

Frequency-specific field combinations
Mutually exclusive field checks
Valid weekday set validation for daily events
Required field enforcement for yearly events

Information

This PR fixes an issue. on_scheduled_event_delete event parameter is useless #1709
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
AI Usage has been disclosed.

…reason

…types

…from audit logs

…ation tests

pycord-app · 2025-12-09T19:51:30Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3025/head:pr-3025
git checkout pr-3025

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head

Lumabots · 2025-12-09T19:53:17Z

Audit Logs still need to be rework (i didnt understand how it work yet)

Lumabots · 2025-12-10T07:09:48Z

should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get
Open of better variable name

Paillat-dev

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-12-12T06:46:23Z

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

when anonymous pr will be merged i'll edit it to make it work

Lulalaby · 2025-12-12T08:29:18Z

fixed ur fux

github-actions · 2026-04-13T15:37:59Z

This pull request does not follow the required pull request template.

Please use the default template (PULL_REQUEST_TEMPLATE.md) and fill out all required sections.

Problems detected:

The line "AI Usage has been disclosed." is missing.

Signed-off-by: Paillat <paillat@pycord.dev>

Co-authored-by: Copilot <copilot@github.com>

Paillat-dev

Also please use from typing_extensions import deprecated and not typing_extensions.deprecated throughout

Paillat-dev · 2026-05-09T13:40:16Z

-        start_time: datetime.datetime = MISSING,
-        end_time: datetime.datetime = MISSING,
-        cover: bytes | None = MISSING,
+        scheduled_start_time: datetime.datetime = MISSING,


breaking change removing start_time and end_time

Paillat-dev · 2026-05-09T13:41:04Z

-            return ScheduledEvent(
-                data=data, guild=self.guild, creator=self.creator, state=self._state
-            )
+        data = await self._state.http.edit_scheduled_event(


Is there a reason why the if payload != {} guard was removed ?

Paillat-dev · 2026-05-09T13:45:00Z

+            return ScheduledEventLocation(
+                state=self._state, value=self.entity_metadata.location
+            )
+        return ScheduledEventLocation(state=self._state, value=self.channel_id)


This property will cause a deprecation warning because of the decorator, but then initiating the ScheduledEventLocation class will itself cause a warning so this will double warn. Add an _internal attribute or similar that makes it not do that.

Paillat-dev · 2026-05-09T13:45:29Z

+    def __str__(self) -> str:
+        return self.location or ""
+
+    def to_payload(self) -> dict[str, str]:


Suggested change

def to_payload(self) -> dict[str, str]:

def to_payload(self) -> dict[str, str | None]:

Paillat-dev · 2026-05-09T13:48:38Z

@@ -289,29 +286,18 @@ class MessageType(Enum):
 class VoiceRegion(Enum):


Unrelated changes

Paillat-dev · 2026-05-09T13:50:35Z

-    from .types.channel import StageChannel, VoiceChannel
    from .types.scheduled_events import ScheduledEvent as ScheduledEventPayload
+else:
+    ConnectionState = None


huh why this ? use "" string typing if really necessary

Paillat-dev · 2026-05-09T13:54:52Z

+        ) = MISSING,
+        entity_type: ScheduledEventEntityType = MISSING,
+        entity_metadata: ScheduledEventEntityMetadata | None = MISSING,
+        channel_id: int = MISSING,


I'm not convinced by this accepting integer ids. We could accept channel: abc.Snowflake instead, so that ppl can pass channels directly as well as discord.Object if they just have an ID. Would be more coherent with the rest of the lib I feel like.

Paillat-dev · 2026-05-09T14:19:39Z

        self.with_member = with_member
        self.before = before
        self.after = after
+        self.use_cache = use_cache


The behavior of use_cache should be documented and maybe a warning be thrown if limit is not None / with_member is false and use_cache is true, since only member objects are returned when using use_cache

Paillat-dev · 2026-05-09T14:21:53Z

            _enum_transformer(enums.NotificationLevel),
        ),
+        "entity_metadata": (None, _transform_entity_metadata),
+        "location": (None, _transform_entity_metadata),


Still confused, location isn't supposed to exist as a top level property on Discord's side no ? So why even do we want to set this if it's never there in the first place ? This code is a mess so I may be wrong here but I'm confused as to why we would handle something Discord doesn't send.

Paillat-dev · 2026-05-09T14:26:12Z

@@ -279,7 +295,7 @@ class AuditLogChanges:
        "status": (None, _enum_transformer(enums.ScheduledEventStatus)),
        "entity_type": (
            "location_type",


This renames it to location_type which makes it go against the entire pr's idea. But at the same time, it would be brekaing to change it without backwards compat.

Lumabots added 6 commits December 9, 2025 15:49

at first i only wanted to add cached members...

43227c4

correcting some bs, like some unknow type added for i dont know what …

fe47678

…reason

use discord variable name, try an implementation for audit logs

fff9b3b

feat: add recurrence support for scheduled events with new enums and …

9e6a986

…types

refactor: remove ScheduledEventLocation class and related attributes …

7b2c31f

…from audit logs

feat: enhance scheduled event recurrence with validation and serializ…

5a2581e

…ation tests

Lumabots requested a review from a team as a code owner December 9, 2025 19:51

pullapprove4 Bot requested a review from Lulalaby December 9, 2025 19:51

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Dec 9, 2025

Lumabots and others added 2 commits December 9, 2025 20:51

Merge branch 'master' into on_scheduled_event_delete

973a3d2

style(pre-commit): auto fixes from pre-commit.com hooks

9d1d5d7

Lumabots and others added 2 commits December 10, 2025 13:39

revert breaking change

8c85a05

style(pre-commit): auto fixes from pre-commit.com hooks

40d79b6

Paillat-dev changed the title ~~feat: Full rework of GuildSchedule~~ fux: GuildSchedule not being cached correctly Dec 10, 2025

Paillat-dev requested changes Dec 10, 2025

View reviewed changes

Comment thread discord/enums.py

Comment thread discord/enums.py Outdated

Comment thread discord/scheduled_events.py

Comment thread discord/scheduled_events.py Outdated

pullapprove4 Bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 10, 2025

Paillat-dev added API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing priority: medium Medium Priority labels Dec 10, 2025

Update discord/enums.py

b5dc3e9

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lulalaby changed the title ~~fux: GuildSchedule not being cached correctly~~ fix: GuildSchedule not being cached correctly Dec 12, 2025

github-actions Bot added the invalid This doesn't seem right label Apr 13, 2026

github-actions Bot closed this Apr 13, 2026

github-actions Bot locked as spam and limited conversation to collaborators Apr 13, 2026

github-project-automation Bot moved this from Todo to Done in Pycord Apr 13, 2026

Paillat-dev reopened this Apr 13, 2026

Paillat-dev removed the invalid This doesn't seem right label Apr 13, 2026

Pycord-Development unlocked this conversation Apr 13, 2026

Paillat-dev and others added 2 commits April 13, 2026 17:48

Merge branch 'master' into on_scheduled_event_delete

7022e67

Signed-off-by: Paillat <paillat@pycord.dev>

style(pre-commit): auto fixes from pre-commit.com hooks

b86cd07

Paillat-dev requested changes Apr 13, 2026

View reviewed changes

Comment thread discord/scheduled_events.py

Comment thread discord/scheduled_events.py Outdated

Comment thread discord/iterators.py Outdated

Comment thread discord/guild.py Outdated

Comment thread discord/scheduled_events.py Outdated

Lulalaby force-pushed the master branch 3 times, most recently from 25347b5 to cc6ebbb Compare April 14, 2026 09:00

Paillat-dev force-pushed the master branch 2 times, most recently from 45025bd to 01e9fa8 Compare April 14, 2026 10:21

Paillat-dev added 2 commits April 17, 2026 18:10

Merge branch 'master' into on_scheduled_event_delete

124169b

feat: Misc changes and fixes

8cd3495

Paillat-dev requested a review from Dorukyum April 17, 2026 17:06

Lumabots and others added 3 commits April 29, 2026 08:30

fix: Refactor comparison methods and update VoiceRegion enum values

61078d3

fix: Add TypeError for unresolved entity_type in Guild class

45c2beb

Co-authored-by: Copilot <copilot@github.com>

Merge branch 'master' into on_scheduled_event_delete

425be22

Lumabots requested review from Lulalaby and Paillat-dev April 29, 2026 07:12

pullapprove4 Bot added the PA: All Contributors pending label Apr 29, 2026

Paillat-dev modified the milestones: v2.8.0, 2.8.1 May 2, 2026

Merge branch 'master' into on_scheduled_event_delete

b01dbcf

Paillat-dev requested changes May 9, 2026

View reviewed changes

pullapprove4 Bot removed the PA: All Contributors pending label May 9, 2026

	def to_payload(self) -> dict[str, str]:
	def to_payload(self) -> dict[str, str \| None]:

		@@ -289,29 +286,18 @@ class MessageType(Enum):
		class VoiceRegion(Enum):

Uh oh!

Conversation

Lumabots commented Dec 9, 2025 • edited by Paillat-dev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app Bot commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 10, 2025

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Dec 12, 2025

Uh oh!

Lulalaby commented Dec 12, 2025

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lumabots commented Dec 9, 2025 •

edited by Paillat-dev

Loading