Skip to content

Add yarn lock file and remove package_lock.json#32

Open
zhoonit wants to merge 1 commit intoPyTorchKorea:masterfrom
zhoonit:deps
Open

Add yarn lock file and remove package_lock.json#32
zhoonit wants to merge 1 commit intoPyTorchKorea:masterfrom
zhoonit:deps

Conversation

@zhoonit
Copy link
Contributor

@zhoonit zhoonit commented Jul 24, 2022

๋ผ์ด์„ ์Šค ๋™์˜

๋ณ€๊ฒฝํ•ด์ฃผ์‹œ๋Š” ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์„ ๋™์˜ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋” ์ž์„ธํ•œ ๋‚ด์šฉ์€ ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๋™์˜ํ•˜์‹œ๋ฉด ์•„๋ž˜ [ ]๋ฅผ [x]๋กœ ๋งŒ๋“ค์–ด์ฃผ์„ธ์š”.

  • ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ํ™•์ธํ•˜์˜€์œผ๋ฉฐ, ๋ณธ PR ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค.

PR ์ข…๋ฅ˜

์ด PR์— ํ•ด๋‹น๋˜๋Š” ์ข…๋ฅ˜ ์•ž์˜ [ ]์„ [x]๋กœ ๋ณ€๊ฒฝํ•ด์ฃผ์„ธ์š”.

  • ํ™ˆํŽ˜์ด์ง€ ๋‚ด์˜ ๋ฌธ์„œ๋ฅผ ์ถ”๊ฐ€/๊ฐœ์„ ํ•˜๋Š” ๊ธฐ์—ฌ
  • ํ™ˆํŽ˜์ด์ง€ ์ž์ฒด๋ฅผ ๊ฐœ์„ ํ•˜๊ฑฐ๋‚˜ ๋ณ€๊ฒฝํ•˜๋Š” ๊ธฐ์—ฌ
  • ์œ„ ์ข…๋ฅ˜์— ํฌํ•จ๋˜์ง€ ์•Š๋Š” ๊ธฐ์—ฌ

PR ์„ค๋ช…

์ด PR๋กœ ๋ฌด์—‡์ด ๋‹ฌ๋ผ์ง€๋Š”์ง€ ๋Œ€๋žต์ ์œผ๋กœ ์•Œ๋ ค์ฃผ์„ธ์š”.

node ํŒจํ‚ค์ง€ ๋งค๋‹ˆ์ €๋กœ yarn ์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ๋Š” ์ ์„ ์ฐธ์กฐํ•˜์—ฌ yarn.lock ํŒŒ์ผ์„ ๋ ˆํฌ์— ๋”ํ•˜๊ณ , package-lock.json ์„ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.

์ฐธ๊ณ : https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for

Copy link
Member

@hyoyoung hyoyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link
Contributor

@Taeyoung96 Taeyoung96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€ PR์ฃผ์…”์„œ ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค! ๐Ÿ‘

Signed-off-by: Jihoon Lee <zhoonit@gmail.com>
Copy link
Member

@hyoyoung hyoyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ผ์ด์„ ์Šค ๋™์˜๊ฐ€ ๋˜์–ด์žˆ์ง€ ์•Š์Šต๋‹ˆ๋‹ค ์ˆ˜์ • ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค

@zhoonit
Copy link
Contributor Author

zhoonit commented Aug 7, 2022

๋ผ์ด์„ ์Šค ๋™์˜๊ฐ€ ๋˜์–ด์žˆ์ง€ ์•Š์Šต๋‹ˆ๋‹ค ์ˆ˜์ • ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค

๋„ต ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค~

Copy link
Member

@hyoyoung hyoyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments