Open
Conversation
Anya497
reviewed
Mar 10, 2026
Anya497
left a comment
Anya497
left a comment
There was a problem hiding this comment.
Looks cool! Just a few refactor comments.
|
|
||
|
|
||
| def get_thread_filepath(uid, filepath): | ||
| base_prefix = TMP_FILE_DIR + "/" |
| writer.writerow(["dll", "method"]) | ||
|
|
||
| for item in parsed_methods: | ||
| if "," in item: |
There was a problem hiding this comment.
When is there no comma in the item? Does it really not need processing?
|
|
||
| result = Methods.parse_frontend_file_to_dll_methods(temp_file.name) | ||
|
|
||
| expected = defaultdict( |
There was a problem hiding this comment.
Can't understand why defaultdict is used here.
There was a problem hiding this comment.
There are multiple duplicate strings with paths that can be moved into a separate variable.
| dll_methods = defaultdict(list) | ||
| for node in selection_tree: | ||
| dll_name = node["title"] + ".dll" | ||
| dll_methods[dll_name] = [] |
There was a problem hiding this comment.
Is it really necessary to explicitly specify the list using defaultdict?
| ): | ||
| with open(front_selection_resource_path, "r") as f: | ||
| content = f.read() | ||
| prefix = "export const METHODS = " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.