Conversation
Replace BytesIO with BufferedStream (SpooledTemporaryFile, 5MB threshold) throughout the fetch and store pipeline to avoid loading large files fully into memory. - Add BufferedStream to utils: stays in memory up to 5MB, spills to disk - Stream HTTP response body via iter_content(1MB chunks) into BufferedStream, hashing on the fly — no more response.content loading full body into memory - Add http_decompress=True option to retrieve_http: stream-decompresses gzip content (e.g. .json.gz from S3) without double-compressing on store - Use BufferedStream in _prepare_write_stream and _prepare_read_stream for compress/decompress in the store - DraftFile.stream typed as BufferedStream with coercing validator for backwards compatibility (accepts BytesIO, bytes, or any readable)
Replace BytesIO with BufferedStream (SpooledTemporaryFile, 5MB threshold) throughout the fetch and store pipeline to avoid loading large files into memory. - Add BufferedStream to utils: stays in memory up to 5MB, spills to disk - Stream HTTP response via iter_content(1MB chunks) into BufferedStream, hashing on the fly — no more response.content loading full body into memory - Detect gzip content (magic bytes) once in retrieve_http, store as DraftFile.content_compression_method — no re-reading the stream later - Gzip files are stored as-is (no recompression CPU cost); size is read from the gzip trailer so file.size always reflects uncompressed data size - _prepare_write_stream uses content_compression_method to skip compression for already-compressed files, and returns the actual compression_method used so File metadata is always correct - DraftFile.stream typed as BufferedStream with coercing validator for backwards compatibility (accepts BytesIO, bytes, or any readable)
- Extract detect_compression() and gzip_uncompressed_size() into utils - Set DraftFile.content_compression_method once on fetch, used by store - Add tests for detect_compression, gzip_uncompressed_size, and http fetch - Format with black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.