fix: widen Variable.sum dim parameter type to DimsLike#820
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
FBumann
approved these changes
Jul 8, 2026
Collaborator
|
@manud99 Thanks for this quick quality fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dimargument inVariable.sumhas a too strict type declaration. It also acceptsIterable[Hashable]because it passes thedimargument toBaseExpression.sum. I adapted the type ofVariable.sumto fix this imprecision.Changes proposed in this Pull Request
Variable.summethod parameter type toDimsLikeChecklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included.