add support for abi3t#556
Conversation
|
Ping @kumaraditya303 - we were just talking about this today. |
|
I confirmed that this resolved the runtime error I reported in #555 |
|
I think we should also add a check that when abi3t is used, the minimum numpy version should be 2.5. |
c2b4c58 to
6c722b0
Compare
|
Looks like 32bit windows still has some issues... not sure why though |
|
My guess is that'd be because there are no wheels for |
|
To me it looks like there are cp315-win32 wheels here and they installed fine. The version specific run had no issues as well. It's just the abi3t run that failed, so I think this is a genuine failure, but I'm not sure which fault it could be: ours, pyo3, numpy or python |
|
I think it could alignment issue on 32 bit MSVC, I am not very familiar with rust but it seems flags is defined as |
|
@Icxolu Can you try forcing a 4 byte alignment layout using |
|
If you all don't sort this out in the meantime I'll try to look on Monday. While win32 isn't so important per se, I do find it useful to detect and sort out CPU architecture-sensitive issues. It's possible this issue is in any one of CPython, NumPy, or rust-numpy. Glad to see everything mostly works otherwise! |
|
I did a bit of digging with compiler explorer: https://godbolt.org/z/qYe3Ghz7a |
This adds abi3t support by
Todo:
See numpy/numpy#31091
Closes #555