Skip to content

ci: use Cargo build warnings setting#6207

Closed
coyaSONG wants to merge 1 commit into
PyO3:mainfrom
coyaSONG:agent/6205-build-warnings
Closed

ci: use Cargo build warnings setting#6207
coyaSONG wants to merge 1 commit into
PyO3:mainfrom
coyaSONG:agent/6205-build-warnings

Conversation

@coyaSONG

Copy link
Copy Markdown

Summary

  • replace the CI job's RUSTFLAGS and RUSTDOCFLAGS warning overrides with Cargo's CARGO_BUILD_WARNINGS: deny setting
  • keep the warning policy scoped to CI

Why

Closes #6205.

Cargo now provides build.warnings specifically for configuring the effective warning level of local packages. Using its environment-variable form removes the need to maintain separate low-level compiler and rustdoc flags.

Impact

This is a CI-only configuration change. It does not affect PyO3's runtime behavior, dependencies, or public API.

Validation

  • parsed .github/workflows/build.yml successfully with Ruby's YAML parser
  • ran git diff --check
  • reviewed the environment mapping against Cargo's build.warnings configuration documentation

The full nox suite was not run because the change only updates the reusable GitHub Actions workflow environment.

Authorship disclosure

This contribution was prepared by OpenAI Codex on behalf of @coyaSONG, after reviewing Contributing.md, the pull request template, and the Code of Conduct.

@davidhewitt

Copy link
Copy Markdown
Member

This automated contribution does not meet our upcoming ai policy #6141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch to build.warnings in CI

2 participants