Skip to content

Skip the reference pool mutex on attach when no decrefs are pending#6200

Open
tobni wants to merge 2 commits into
PyO3:mainfrom
tobni:pool-dirty-flag
Open

Skip the reference pool mutex on attach when no decrefs are pending#6200
tobni wants to merge 2 commits into
PyO3:mainfrom
tobni:pool-dirty-flag

Conversation

@tobni

@tobni tobni commented Jul 12, 2026

Copy link
Copy Markdown

Closes #6199.

@tobni tobni force-pushed the pool-dirty-flag branch from 4bf1eff to 1fa73e7 Compare July 12, 2026 21:41
@tobni tobni force-pushed the pool-dirty-flag branch from 1fa73e7 to bf64a85 Compare July 12, 2026 21:42
@codspeed-hq

codspeed-hq Bot commented Jul 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 26.84%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 139 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
into_u128_max 1.5 µs 2.1 µs -26.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing tobni:pool-dirty-flag (bf64a85) with main (8fcf8fc)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference pool mutex is taken on every attach which serializes multithreaded embedders

1 participant