more cleanup of private FFI definitions#6042
Open
davidhewitt wants to merge 7 commits into
Open
Conversation
davidhewitt
commented
May 13, 2026
Comment on lines
+391
to
+394
| $pub struct $name { | ||
| _data: (), | ||
| _marker: core::marker::PhantomData<(*mut u8, core::marker::PhantomPinned)>, | ||
| } |
Member
Author
There was a problem hiding this comment.
This change was motivated by looking at the nomicon https://doc.rust-lang.org/nomicon/ffi.html#representing-opaque-structs - which documents this _data / _marker combination as the current way to do opaque types.
Open
ngoldbaum
approved these changes
May 25, 2026
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Everything looks correct to me. Thank you for the ping to look this over, I missed it in the churn.
Contributor
|
That said there's a merge conflict now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another batch of FFI cleanups following #5965
I added
--document-private-itemsto the ffi-check rustdoc processing; this didn't catch functions (which I hoped it would) but it noticed that thePyTracebackObjectdefinition did not expose the fields.I also adjusted the implementation of
PyErr_BadInternalCallto be more like the CPython headers, where it is a macro which accepts__FILE__and__LINE__information.