Revert "Make IntoPyObject for Bound & Borrowed more generic"#5832
Merged
bschoenmaeckers merged 1 commit intomainfrom Feb 19, 2026
Merged
Revert "Make IntoPyObject for Bound & Borrowed more generic"#5832bschoenmaeckers merged 1 commit intomainfrom
IntoPyObject for Bound & Borrowed more generic"#5832bschoenmaeckers merged 1 commit intomainfrom
Conversation
)" This reverts commit ee66c21.
| fn into_pyobject(self, py: Python<'py>) -> Result<Self::Output, Self::Error> { | ||
| Ok(self.as_unbound().bind_borrowed(py)) | ||
| fn into_pyobject(self, _py: Python<'py>) -> Result<Self::Output, Self::Error> { | ||
| Ok(*self) |
Member
There was a problem hiding this comment.
We could keep the other cases except this one I think.
Member
There was a problem hiding this comment.
I was thinking about this further, and it occurred to me that one place where the lifetimes differ in the future might be subinterpreters.
Maybe given that were not entirely sure how that will play out, better to play cautious and not relax these implementations until a user asks for it?
bschoenmaeckers
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5831 as it introduces unsoundness, see #5831 (comment)