delete some unneeded complexity from PyMethodDefType#5581
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Oct 31, 2025
Merged
delete some unneeded complexity from PyMethodDefType#5581davidhewitt merged 2 commits intoPyO3:mainfrom
PyMethodDefType#5581davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
LilyFirefly
reviewed
Oct 31, 2025
Comment on lines
479
to
+480
| let (default_class_geitem, default_class_geitem_method) = | ||
| pyclass_class_geitem(&args.options, &syn::parse_quote!(#cls), ctx)?; | ||
| pyclass_class_getitem(&args.options, &syn::parse_quote!(#cls), ctx)?; |
Contributor
There was a problem hiding this comment.
If we're fixing the pyclass_class_getitem typo, we might as well fix default_class_geitem and default_class_geitem_method here too (and lower in this function).
Member
Author
|
(Looks like the build on windows arm runner hung in the codecov upload.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #5551
The
PyMethodDefTypeenum had distinctions forclassmethodandstaticmethodwhich were redundant anyway due to flags stored within the method def, this PR simplifies the enum.Not a user-facing change.