-
Notifications
You must be signed in to change notification settings - Fork 959
ci: Add 3.15 in CI #5518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ci: Add 3.15 in CI #5518
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2c1fd27
Add 3.15 testing in ci.yml
clin1234 2b1bc17
Create 5518-packaging.md
clin1234 fdffee3
Update .github/workflows/ci.yml
clin1234 761db77
Update Python version compatibility in pyo3-ffi/Cargo.toml
clin1234 7439eea
Typo
clin1234 aa4c3d4
Add `abi3-py315` in pyo3-build-config/Cargo.toml
clin1234 57f95d1
Add abi3-py315 in Cargo.toml
clin1234 cf0bcac
Bump max supported CPython version in noxfile.py
clin1234 af8eb8c
Bump max CPython version in pyo3-ffi/build.rs
clin1234 23f680f
Lint noxfile.py encountered by PyLance
clin1234 9662b22
Closer match of PyObject's definition in 3.15t
clin1234 331b886
tmp
clin1234 78137d4
fix ffi-check on the free-threaded build
ngoldbaum c919a1a
fix test failures on the free-threaded build
ngoldbaum 94fe4bb
Update ABI3_MAX_MINOR
ngoldbaum 79546bd
revert most changes to the noxfile
ngoldbaum d72f1a3
Fix free-threaded build on <3.15
ngoldbaum 215c416
revert changes to moduleobject bindings
ngoldbaum 67ca99b
fix ffi-check on 3.13t and 3.14t
ngoldbaum be18bd8
fix 3.13t for real
ngoldbaum 9ce3ce0
adjust ob_flags setup and fix conditional compilation
ngoldbaum b873ad9
disable abi3-py315 for now
ngoldbaum 43fd6c7
rework PyObject 4-byte alignment to more closely follow upstream
ngoldbaum 00441c4
disable abi3-py315 for now
ngoldbaum af4bb11
fix check-feature-powerset and test-version-limits
ngoldbaum 2a33e2d
really fix test-version-limits
ngoldbaum 34bd3d5
run ruff
ngoldbaum 4cc0aff
Remove free-threaded versions from ABI3_PY_VERSIONS
ngoldbaum 032d532
fix ffi-check on free-threaded build
ngoldbaum 6c4ce7f
Allow experimental builds of alpha releases of CPython
ngoldbaum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,6 +234,8 @@ jobs: | |
| "3.13t", | ||
| "3.14", | ||
| "3.14t", | ||
| "3.15-dev", | ||
| "3.15t-dev", | ||
| "pypy3.11", | ||
| "graalpy25.0", | ||
| ] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add 3.15 to CI for preliminary testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be worth briefly discussing what the alternatives to bumping this number are. Could we make a rule that
max + 1will always build and run with warnings (maybe with an env var to turn off the warnings)?My worry is that packages built against PyO3 0.28 might not be using 3.15 yet, but in the future when 3.15's ABI has both changed and finalised, users might install packages built with PyO3 0.28 on 3.15.0, get no warnings, and then get an instant crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me see how painful this is to set up. Seems sensible.
By "build with warnings" are you talking about the same kind of warning we already generate when someone tries to build a stable ABI extension on the free-threaded build?