Conversation
feat: extend pwd_slope_estimate to 3d
* ci: move to arm64 in Azure Pipelines (to fix llvmlite install error)
- stripped down `matvec` + `matmat` methods to solely rely on `matvec` - stripped down `reshape`-logic
…ssin.interpspline`
- moved utilities for interpolation to `_interp_utils.py` - fixed floating point rounding error of penultimate sample clipping behaviour for linear interpolation - transitioned `CubicSplineInterpolator` to `InterpCubicSpline` and enriched its docs (1 TODO, Notes missing)
- exposed `InterpCubicSpline` - made clipping logic for penultimate sample more natural by just going via the size of `iava`
- exposed `InterpCubicSpline`
- added `InterpCubicSpline`
- fixed missing naming update for `iava` clipping
- implemented matrix solver for when `dims[axis] == 2` - updated docs for minimum number of samples
- thoroughly tests `InterpCubicSpline` against `scipy.interpolate.CubicSpline`
Fix Intel CI
- added `bc_type` argument to be forwards-compatible with the potential addition for further boundary conditions
- fixed typo
- fixed failing checks introduced with `bc_type`
- made casting to complex more explicit
- used `pytest.params` with `id` to make tests self-documenting without relying on comments - transitioned test specifications to a `dataclass` to avoid typos in key-based access with hard-coded strings - added typing
- removed duplicated code for non-unique `iava`-checks
- check `with pytest.raises` for actual error message - this uncovered a bug in the tests for `Bilinear` that only tested for a `ValueError` being raised in the `iava`-duplicate logic, but this was already raised during the attempt of element duplication in `iava` itself
- added `References` and `Notes` to `InterpCubicSpline`
Pin minconda version in Intel MKL Tests
Fix: dtype consistency in operators
Build: switch from setuptools to hatchling
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 2 high |
| Security | 2 medium |
| Complexity | 12 medium |
🟢 Metrics 135 complexity · -8 duplication
Metric Results Complexity 135 Duplication -8
🟢 Coverage 64.64% diff coverage
Metric Results Coverage variation Report missing for b53fec81 Diff coverage ✅ 64.64% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (b53fec8) Report Missing Report Missing Report Missing Head commit (ebe4e15) 10918 8977 82.22% Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#749) 987 638 64.64% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.