Skip to content

increase the led hole diameter (CLOSES #496) #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yhya99 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

increase the led hole diameter (CLOSES #496) #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c372569
enclosure/imported_scadModels/B_shell.scad, add the LEDdiameter param…
Yhya99 Jul 17, 2026
5f228ee
Bump GPAD firmware version
github-actions[bot] Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Firmware/GPAD_API/FIRMWARE_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.58.5
0.58.6
7 changes: 4 additions & 3 deletions enclosure/imported_scadModels/B_shell.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use <PartNumbering.scad>


PartName = "BShell";
PartVersion = "V4.0";
PartVersion = "V4.1";
Date = "26141";

speaker_ring = 1;
Expand All @@ -19,6 +19,7 @@ speaker_ring = 1;
LEDspacing = 12.7 ;
LEDYposOffset = 15.24 ; // offset from the Encoder edge of PCB
LEDXposOffset = 27.94 ; // offset from the connector edge of PCB
LEDdiameter= 5.1;
////////////////////////////////////////////////////////////////////

////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -101,7 +102,7 @@ color( Couleur1,1){
translate( [3*Thick+2,Thick+5,0]){ //([-.5,0,0]){
//(On/Off, Xpos, Ypos, Diameter)
for ( i = [-6.5:-2.5] ){
CylinderHole(1,PCBLength-(LEDXposOffset+LEDspacing*i),LEDYposOffset,5); //LED1 , switch signs to move downwards ??Question
CylinderHole(1,PCBLength-(LEDXposOffset+LEDspacing*i),LEDYposOffset,LEDdiameter); //LED1 , switch signs to move downwards ??Question
}
//CylinderHole(1,PCBLength-46.99,PCBWidth-FootPosX,5); //LED6 power //??Question extra?
//(On/Off, Xpos,Ypos,Length,Width,Filet)
Expand All @@ -118,7 +119,7 @@ translate( [3*Thick+2,Thick+5,0]){ //([-.5,0,0]){
// (On/Off, Xpos, Ypos, Diameter)
SpeakerHole(1, Krake_rev2_76mmSPK ? SpeakerPositionX+2.5-(3*Thick+2) : SpeakerHoleX, Krake_rev2_76mmSPK ?SpeakerPositionY+9-(Thick+5):SpeakerHoleY ,SpeakerDiameter_mm/2.5-1.5,Ccenter=true); //Buzzer // Speaker
//LED hole generator unsure why this works ??Question repeated commented to avoid confusion
CylinderHole(1,PCBLength-46.99+translationVariable,PCBWidth-FootPosX,5); //LED6 power light ??Question delete extra
CylinderHole(1,PCBLength-46.99+translationVariable,PCBWidth-FootPosX,LEDdiameter); //LED6 power light ??Question delete extra
//(On/Off, Xpos,Ypos,Length,Width,Filet)
SquareHole(1,DisplayXpos,DisplayYpos,DisplayLenght,DisplayWidth,DisplayFilet,Ccenter=true); //Display
CylinderHole(1,SpeakerHoleX,68.58,2); //reset hole
Expand Down
Binary file removed enclosure/parts_toPrint/U_Box_V105_Krake_RevB_BShell_V4.0.stl
View file
Open in desktop
Binary file not shown.
Binary file added enclosure/parts_toPrint/U_Box_V105_Krake_RevB_BShell_V4.1.stl
View file
Open in desktop
Binary file not shown.