Refactored Factory Test code Using AI#564
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c88333a8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true; | ||
| startOTAServerIfNeeded(); // start OTA while AP is active so /update is reachable | ||
|
|
||
| bool ok = promptYesNo( |
There was a problem hiding this comment.
In the Wi-Fi AP test, ok was already declared for the WiFi.softAP(...) result earlier in the same function, so declaring bool ok again for the operator prompt causes this sketch to fail to compile when the factory-test firmware is built. Reuse the existing variable or give the prompt result a different name.
Useful? React with 👍 / 👎.
1 participant
No description provided.