fix(app): make npm cli bin executable via shebang#91
Merged
skulidropek merged 1 commit intoProverCoderAI:mainfrom Feb 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDD proof (publisher vs consumer game)
We model release as a two-player game:
docker-gitvia package managers (pnpm,npm,npx).A stable outcome requires both strategies to succeed on the same tarball.
Red (failing test before fix)
bash scripts/e2e/local-package-cli.shfailed with:packed CLI entrypoint missing shebang: expected '#!/usr/bin/env node'import: not foundwhen invokingdocker-git.Green (fix)
packages/app/src/docker-git/main.tsdist/src/docker-git/main.jsstarts with#!/usr/bin/env nodepnpm docker-git --helpnpm exec -- docker-git --helpResult
The same TDD test now passes end-to-end:
bash scripts/e2e/local-package-cli.sh✅Verification
pnpm --filter ./packages/app build:docker-gitbash scripts/e2e/local-package-cli.shpnpm --filter ./packages/app typecheckpnpm --filter ./packages/app test