Updates typehints based on expected values#12
Open
gms8994 wants to merge 1 commit intoPromPHP:mainfrom
Open
Conversation
Updates tests to include php8.2 Updates to use latest phpstan
Author
|
@LKaemmerling is this something that can be reviewed? Is there a process that I should follow, or someone else I should tag in a comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started out as just updating the typehints on the PushGateway class to reflect what
$groupingKeyactually represents, but quickly I had to make some adjustments to allow things to be tested on php8.2 and update to later versions of GitHub workflows, phpstan, and correct some guzzle requirements.