Added basic support for redis sentinel based on https://github.com/Namoshek/laravel-redis-sentinel#184
Open
Jacq wants to merge 14 commits intoPromPHP:mainfrom
Open
Added basic support for redis sentinel based on https://github.com/Namoshek/laravel-redis-sentinel#184Jacq wants to merge 14 commits intoPromPHP:mainfrom
Jacq wants to merge 14 commits intoPromPHP:mainfrom
Conversation
Member
|
Hey, thank you for your work. Would it be possible to add tests based on |
Author
Already added some test and performed a full refactor based on a different repo, using phpredis sentinel support. |
e1a542d to
e531f94
Compare
Author
|
Added tests, ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged and refactor code with from old fork #https://github.com/ml65/prometheus_client_php that supports redis sentinel by updating master address/port options before redis connections.