Skip to content

💥 mp_regenをmp_healに改名#2247

Open
Lapis-LJA wants to merge 5 commits intomasterfrom
fix/lapis_modifier_mp_heal
Open

💥 mp_regenをmp_healに改名#2247
Lapis-LJA wants to merge 5 commits intomasterfrom
fix/lapis_modifier_mp_heal

Conversation

@Lapis-LJA
Copy link
Contributor

Fix #1726

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Issue #1726 対応として、MP回復量 Modifier の名称・参照を mp_regen / MPRegen から mp_heal / MPHeal に改名し、関連する呼び出し箇所と API 関数群を更新するPRです。

Changes:

  • God 効果や Artifact lore 生成など、api:modifier/mp_regen/* 呼び出しを api:modifier/mp_heal/* に置換
  • プレイヤー属性ストレージのキーを MPRegenMPHeal に更新(初期値含む)
  • api:modifier/mp_regen/get を廃止し、api:modifier/mp_heal/get を新設。MP回復計算側も新しい戻り値キーへ更新

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TheSkyBlessing/data/player_manager/functions/god/wi-ki/unbelieve.mcfunction Wi-ki 効果解除での MP回復 Modifier の参照先を mp_heal に更新
TheSkyBlessing/data/player_manager/functions/god/wi-ki/believe.mcfunction Wi-ki 効果付与での MP回復 Modifier の参照先を mp_heal に更新
TheSkyBlessing/data/player_manager/functions/god/rumor/passive/set.mcfunction Rumor パッシブ付与での参照先を mp_heal に更新
TheSkyBlessing/data/player_manager/functions/god/rumor/passive/remove.mcfunction Rumor パッシブ解除での参照先を mp_heal に更新
TheSkyBlessing/data/core/functions/handler/first_join.mcfunction 初期属性のキーを MPHeal に変更
TheSkyBlessing/data/asset_manager/functions/artifact/create/set_lore/modifier/.mcfunction Artifact Modifier type 表示を mp_heal に更新
TheSkyBlessing/data/api/functions/modifier/mp_regen/get.mcfunction mp_regen getter を削除
TheSkyBlessing/data/api/functions/modifier/mp_heal/remove.mcfunction mp_heal remove API への改名・呼び出し先更新
TheSkyBlessing/data/api/functions/modifier/mp_heal/get.mcfunction mp_heal getter を新設(Return キーも MPHeal
TheSkyBlessing/data/api/functions/modifier/mp_heal/add.mcfunction mp_heal add API への改名・呼び出し先更新
TheSkyBlessing/data/api/functions/modifier/core/mp_heal/remove.mcfunction core remove の対象キーを MPHeal に更新
TheSkyBlessing/data/api/functions/modifier/core/mp_heal/add.mcfunction core add の対象キーを MPHeal に更新
TheSkyBlessing/data/api/functions/damage/core/mp_heal.mcfunction 補正取得先を mp_heal/getReturn.MPHeal に更新

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#
# @input as player
# @output storage api:
# Return.Heal : double
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@output の記載が Return.Heal になっていますが、この関数は Return.MPHeal を返しています(下の data remove/modify も MPHeal)。APIドキュメントとして誤解を招くので Return.MPHeal : double に修正してください。

Suggested change
# Return.Heal : double
# Return.MPHeal : double

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPRegen を MPHeal に改名する

2 participants