Open
Conversation
There was a problem hiding this comment.
Pull request overview
Issue #1726 対応として、MP回復量 Modifier の名称・参照を mp_regen / MPRegen から mp_heal / MPHeal に改名し、関連する呼び出し箇所と API 関数群を更新するPRです。
Changes:
- God 効果や Artifact lore 生成など、
api:modifier/mp_regen/*呼び出しをapi:modifier/mp_heal/*に置換 - プレイヤー属性ストレージのキーを
MPRegen→MPHealに更新(初期値含む) api:modifier/mp_regen/getを廃止し、api:modifier/mp_heal/getを新設。MP回復計算側も新しい戻り値キーへ更新
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TheSkyBlessing/data/player_manager/functions/god/wi-ki/unbelieve.mcfunction | Wi-ki 効果解除での MP回復 Modifier の参照先を mp_heal に更新 |
| TheSkyBlessing/data/player_manager/functions/god/wi-ki/believe.mcfunction | Wi-ki 効果付与での MP回復 Modifier の参照先を mp_heal に更新 |
| TheSkyBlessing/data/player_manager/functions/god/rumor/passive/set.mcfunction | Rumor パッシブ付与での参照先を mp_heal に更新 |
| TheSkyBlessing/data/player_manager/functions/god/rumor/passive/remove.mcfunction | Rumor パッシブ解除での参照先を mp_heal に更新 |
| TheSkyBlessing/data/core/functions/handler/first_join.mcfunction | 初期属性のキーを MPHeal に変更 |
| TheSkyBlessing/data/asset_manager/functions/artifact/create/set_lore/modifier/.mcfunction | Artifact Modifier type 表示を mp_heal に更新 |
| TheSkyBlessing/data/api/functions/modifier/mp_regen/get.mcfunction | 旧 mp_regen getter を削除 |
| TheSkyBlessing/data/api/functions/modifier/mp_heal/remove.mcfunction | mp_heal remove API への改名・呼び出し先更新 |
| TheSkyBlessing/data/api/functions/modifier/mp_heal/get.mcfunction | mp_heal getter を新設(Return キーも MPHeal) |
| TheSkyBlessing/data/api/functions/modifier/mp_heal/add.mcfunction | mp_heal add API への改名・呼び出し先更新 |
| TheSkyBlessing/data/api/functions/modifier/core/mp_heal/remove.mcfunction | core remove の対象キーを MPHeal に更新 |
| TheSkyBlessing/data/api/functions/modifier/core/mp_heal/add.mcfunction | core add の対象キーを MPHeal に更新 |
| TheSkyBlessing/data/api/functions/damage/core/mp_heal.mcfunction | 補正取得先を mp_heal/get と Return.MPHeal に更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # | ||
| # @input as player | ||
| # @output storage api: | ||
| # Return.Heal : double |
There was a problem hiding this comment.
@output の記載が Return.Heal になっていますが、この関数は Return.MPHeal を返しています(下の data remove/modify も MPHeal)。APIドキュメントとして誤解を招くので Return.MPHeal : double に修正してください。
Suggested change
| # Return.Heal : double | |
| # Return.MPHeal : double |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1726