fix: normalize tokenStandard to uppercase in getAssetItemType#1964
Open
qsysvcore wants to merge 1 commit intoProjectOpenSea:mainfrom
Open
fix: normalize tokenStandard to uppercase in getAssetItemType#1964qsysvcore wants to merge 1 commit intoProjectOpenSea:mainfrom
qsysvcore wants to merge 1 commit intoProjectOpenSea:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The getAssetItemType function in src/utils/protocol.ts uses a switch statement with uppercase token standard strings ("ERC20", "ERC721", "ERC1155"), but doesn't normalize the input. When the API returns token standards in lowercase or mixed case (e.g., "erc721", "Erc721"), the function incorrectly throws "Unknown schema name" error.
Fix
Added
tokenStandard.toUpperCase()normalization at the beginning of the function to ensure case-insensitive matching.Why this is safe
toUpperCase()when calling this function)TokenStandardtype already defines the values in uppercase, so this ensures runtime values match the type definitions