Enhanced cancellation note clarity#1882
Closed
0x0v4 wants to merge 1 commit intoProjectOpenSea:mainfrom
Closed
Conversation
ryanio
requested changes
Feb 11, 2026
Collaborator
ryanio
left a comment
There was a problem hiding this comment.
Thanks for the contribution! However, the added parenthetical restates what the original bullet already conveys — "cancellation only assured if no fulfillment signature was vended" already implies that if a signature was vended, the order may still be fulfillable.
Closing in favor of keeping the existing concise wording. If you'd like to contribute, we'd welcome improvements that add new information rather than restating existing content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an explicit clarification that if a fulfillment signature was already generated, the order may still be fulfillable even after cancellation.