Skip to content

Enhanced cancellation note clarity#1882

Closed
0x0v4 wants to merge 1 commit intoProjectOpenSea:mainfrom
0x0v4:main
Closed

Enhanced cancellation note clarity#1882
0x0v4 wants to merge 1 commit intoProjectOpenSea:mainfrom
0x0v4:main

Conversation

@0x0v4
Copy link
Copy Markdown

@0x0v4 0x0v4 commented Jan 20, 2026

Added an explicit clarification that if a fulfillment signature was already generated, the order may still be fulfillable even after cancellation.

Copy link
Copy Markdown
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! However, the added parenthetical restates what the original bullet already conveys — "cancellation only assured if no fulfillment signature was vended" already implies that if a signature was vended, the order may still be fulfillable.

Closing in favor of keeping the existing concise wording. If you'd like to contribute, we'd welcome improvements that add new information rather than restating existing content.

@ryanio ryanio closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants