fix(dsl): resolve two script_mod runtime errors#164
Merged
Conversation
- room_screen: drop invalid `visible` property on Splash widget (not a View) - styles: add missing SETTINGS_REGULAR_TEXT_STYLE token (ported from upstream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Makepad
script_mod!runtime errors that spammed the log on every startup.Changes
room_screen.rs: removed the invalidvisible: falseproperty on theSplashwidget.Splashis a custom widget (not aView) and has novisiblefield, so the property was rejected at load. Its visibility is already driven by itsbodycontent (empty body renders nothing), so behavior is unchanged.styles.rs: added the missingSETTINGS_REGULAR_TEXT_STYLEtoken (and itsSETTINGS_REGULAR_FONT_SIZE). It was referenced 4× inapp_settings.rs(introduced by the upstream sync in sync: migrate upstream app settings and align zoom/view-mode behavior #148) but its definition was never ported. Copied verbatim from upstream robrix.Verification
cargo buildpasses.room_screen.rs:2021andapp_settings.rs:51/95/170/291errors no longer appear.