chore(ci): upgrade pipeline to ubuntu-26.04 (minus ARM)#7624
Open
DennisOSRM wants to merge 3 commits into
Open
chore(ci): upgrade pipeline to ubuntu-26.04 (minus ARM)#7624DennisOSRM wants to merge 3 commits into
DennisOSRM wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates GitHub Actions CI to target newer runner images (Ubuntu 26.04) and refreshes the build matrix, while keeping ARM Linux separate.
Changes:
- Switch several workflows from
ubuntu-24.04toubuntu-26.04. - Adjust
osrm-backendCI job naming and compiler/build variants (new clang-20 debug jobs, gcc-15, LTO toggles). - Remove an explanatory CMake comment around the “always link release TBB” behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Removes rationale comment for forcing release TBB linkage. |
| .github/workflows/vcpkg-smoke.yml | Updates Linux runner to ubuntu-26.04 for vcpkg smoke tests. |
| .github/workflows/stale.yml | Moves stale action runner to ubuntu-26.04. |
| .github/workflows/osrm-backend.yml | Migrates jobs to ubuntu-26.04, refactors matrix entries/names, updates compiler coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+375
to
378
| - name: linux-arm64-release | ||
| continue-on-error: false | ||
| node: 24 | ||
| runs-on: ubuntu-24.04-arm |
Comment on lines
397
to
400
| find_package(TBB CONFIG REQUIRED) | ||
| # Always link the release build of TBB, even in Debug/Coverage configurations. | ||
| # vcpkg's debug TBB enables internal debug assertions (e.g. intrusive_list | ||
| # invariants) that trip during osrm-extract's test-data generation on | ||
| # ubuntu-24.04 under gcc-13. The master branch never hit this because it | ||
| # linked the system's release-only TBB. Do the same here. | ||
| foreach(_tbb_target TBB::tbb TBB::tbbmalloc TBB::tbbmalloc_proxy) | ||
| if(TARGET ${_tbb_target}) | ||
| set_target_properties(${_tbb_target} PROPERTIES |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.