ci: re-enable Windows unit tests#7419
Draft
Claude wants to merge 9 commits into
Draft
Conversation
- Add /MP2 flag to MSVC compiler to limit parallel compilation - Use --parallel 1 for cmake build to reduce memory pressure - Add explicit -A x64 flag to ensure 64-bit toolchain is used - Re-enable test building and execution in Windows CI workflow Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/56738ea6-f252-48af-931a-34dd004d9204
This limits parallelisation even further
Removed CXXFLAGS from the cmake command in the Build step.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7419 +/- ##
==========================================
+ Coverage 90.81% 90.82% +0.01%
==========================================
Files 484 484
Lines 37817 37816 -1
==========================================
+ Hits 34343 34347 +4
+ Misses 3474 3469 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove CXXFLAGS from environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI was disabled in #6930 due to MSVC running out of heap space (
C1060: compiler is out of heap space) when building unit tests. This was caused by excessive parallel compilation processes consuming available memory on the CI runner.Changes
/MP2flag for MSVC to limit parallel compilation to 2 processes per invocation--parallel 1to cmake build commands to enforce sequential project builds-A x64flag to explicitly use 64-bit toolchainApproach
Two-level memory control:
/MP2): Limits MSVC to 2 parallel translation units per compilation--parallel 1): Forces sequential target builds across the projectThis reduces peak memory usage while maintaining some parallelism within individual compilation steps.
Original prompt