Skip to content

tests: remove duplicate test cases in transforms#8949

Open
bhardwajjvaibhav wants to merge 1 commit into
Project-MONAI:devfrom
bhardwajjvaibhav:fix/remove-duplicate-test-cases
Open

tests: remove duplicate test cases in transforms#8949
bhardwajjvaibhav wants to merge 1 commit into
Project-MONAI:devfrom
bhardwajjvaibhav:fix/remove-duplicate-test-cases

Conversation

@bhardwajjvaibhav

Copy link
Copy Markdown

Fixes #8942

Removed duplicate entries from test case lists in the transforms test files.

Files changed:

  • tests/transforms/test_border_pad.py
  • tests/transforms/test_border_padd.py
  • tests/transforms/test_center_spatial_crop.py
  • tests/transforms/test_spatial_padd.py

Each file had byte-identical duplicate entries in their test case lists
as identified by the script in issue #8942. Duplicates were removed and
all affected tests verified passing locally.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Duplicate parameterized test cases were removed from several transform test lists. The remaining cases and expected shapes or validity flags were unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: removing duplicate transform test cases.
Description check ✅ Passed It covers the issue reference, summarizes the cleanup, lists affected files, and notes local test verification.
Linked Issues check ✅ Passed The PR addresses #8942 by cleaning duplicate transform test entries in the listed files without changing test intent.
Out of Scope Changes check ✅ Passed The changes stay focused on transform test-case cleanup; no unrelated edits are indicated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bhardwajjvaibhav bhardwajjvaibhav force-pushed the fix/remove-duplicate-test-cases branch 2 times, most recently from 5a6a5ff to 20fb430 Compare June 25, 2026 08:41
Fixes Project-MONAI#8942

Removed byte-identical duplicate entries from test case lists in transforms.

Files changed:
- tests/transforms/test_border_pad.py
- tests/transforms/test_border_padd.py
- tests/transforms/test_center_spatial_crop.py
- tests/transforms/test_spatial_padd.py

Signed-off-by: bhardwajjvaibhav <bhardwajvaibhav2097@gmail.com>

Signed-off-by: bhardwajjvaibhav <bhardwajvaibhav2097@gmail.com>
@bhardwajjvaibhav bhardwajjvaibhav force-pushed the fix/remove-duplicate-test-cases branch from feab14e to bb90398 Compare June 25, 2026 11:24
@aymuos15

Copy link
Copy Markdown
Contributor

Sorry for not tagging the issue, I made the PR before it was created but I think this has now been solved with #8896 (merged), which removed these same duplicate entries from all four files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Candidate Duplicate Test Cases For Cleanup

2 participants