Skip to content

fix: replace {nodeid} placeholder in versioned_docs#509

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/versioned-nodeid
Open

fix: replace {nodeid} placeholder in versioned_docs#509
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/versioned-nodeid

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Replace {nodeid} with in kubectl label commands across all versioned docs (v1.3.0 through v2.9.0).

Summary by CodeRabbit

  • Documentation
    • Clarified the Kubernetes node-labeling examples across multiple versioned setup and Helm guides.
    • Replaced the {nodeid} placeholder with the more readable <node-name> in kubectl label commands.
    • Kept the required gpu=on label and all other setup steps unchanged.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot

hami-robot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 3b3e950
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a3ed400a65a9300080373e5
😎 Deploy Preview https://deploy-preview-509--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 44ca8715-f08b-446b-b66c-381b891765fd

📥 Commits

Reviewing files that changed from the base of the PR and between a3e36d4 and 3b3e950.

📒 Files selected for processing (16)
  • versioned_docs/version-v1.3.0/get-started/nginx-example.md
  • versioned_docs/version-v1.3.0/installation/prerequisites.md
  • versioned_docs/version-v2.4.1/get-started/nginx-example.md
  • versioned_docs/version-v2.4.1/installation/prerequisites.md
  • versioned_docs/version-v2.5.0/get-started/nginx-example.md
  • versioned_docs/version-v2.5.0/installation/prerequisites.md
  • versioned_docs/version-v2.5.1/get-started/nginx-example.md
  • versioned_docs/version-v2.5.1/installation/prerequisites.md
  • versioned_docs/version-v2.6.0/get-started/nginx-example.md
  • versioned_docs/version-v2.6.0/installation/prerequisites.md
  • versioned_docs/version-v2.7.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.7.0/installation/prerequisites.md
  • versioned_docs/version-v2.8.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.8.0/installation/prerequisites.md
  • versioned_docs/version-v2.9.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.9.0/installation/prerequisites.md

📝 Walkthrough

Walkthrough

Versioned documentation updates the kubectl label nodes examples to use <node-name> instead of {nodeid} across get-started and installation guides.

Changes

Node-label placeholder docs

Layer / File(s) Summary
Get-started examples
versioned_docs/version-v1.3.0/get-started/nginx-example.md, versioned_docs/version-v2.4.1/get-started/nginx-example.md, versioned_docs/version-v2.5.0/get-started/nginx-example.md, versioned_docs/version-v2.5.1/get-started/nginx-example.md, versioned_docs/version-v2.6.0/get-started/nginx-example.md, versioned_docs/version-v2.7.0/get-started/deploy-with-helm.md, versioned_docs/version-v2.8.0/get-started/deploy-with-helm.md, versioned_docs/version-v2.9.0/get-started/deploy-with-helm.md
The get-started docs update the node placeholder in the kubectl label example to <node-name>.
Prerequisites examples
versioned_docs/version-v1.3.0/installation/prerequisites.md, versioned_docs/version-v2.4.1/installation/prerequisites.md, versioned_docs/version-v2.5.0/installation/prerequisites.md, versioned_docs/version-v2.5.1/installation/prerequisites.md, versioned_docs/version-v2.6.0/installation/prerequisites.md, versioned_docs/version-v2.7.0/installation/prerequisites.md, versioned_docs/version-v2.8.0/installation/prerequisites.md, versioned_docs/version-v2.9.0/installation/prerequisites.md
The installation prerequisites docs update the same kubectl label example placeholder to <node-name>.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A bunny hopped through docs so bright,
And swapped the node name left and right.
{nodeid} went poof, hooray! 🐰
<node-name> now leads the way,
With carrots, clarity, and light.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing the {nodeid} placeholder across versioned docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/M label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant