Skip to content

Fetch latest subject before opening editor#708

Merged
malberts merged 1 commit intomasterfrom
fetch-subject-before-edit
Apr 6, 2026
Merged

Fetch latest subject before opening editor#708
malberts merged 1 commit intomasterfrom
fetch-subject-before-edit

Conversation

@JeroenDeDauw
Copy link
Copy Markdown
Member

The Infobox opened the SubjectEditorDialog with whatever subject data
was in the store cache. If the subject was modified in another tab,
the editor would show stale data. Now fetch the latest subject from
the server before opening the editor, matching the pattern already
used by SchemaDisplay and LayoutDisplay.

Test plan

  • Open a subject page with an infobox in two tabs
  • Edit the subject in the second tab and save
  • In the first tab, click the edit button on the infobox
  • Verify the editor shows the updated data from the second tab

Prompted by @JeroenDeDauw after noticing the inconsistency with Schema/Layout editors.
Context: the NeoWiki codebase and ADR 016 (Frontend State Management).
Written by Claude Code, Opus 4.6

🤖 Generated with Claude Code

The Infobox opened the SubjectEditorDialog with whatever subject data
was in the store cache. If the subject was modified in another tab,
the editor would show stale data. Now fetch the latest subject from
the server before opening the editor, matching the pattern already
used by SchemaDisplay and LayoutDisplay.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@JeroenDeDauw JeroenDeDauw marked this pull request as ready for review April 3, 2026 16:11
@JeroenDeDauw
Copy link
Copy Markdown
Member Author

tested locally. LGTM

@JeroenDeDauw JeroenDeDauw requested a review from malberts April 3, 2026 16:12
@malberts malberts merged commit 25ba3ad into master Apr 6, 2026
6 checks passed
@malberts malberts deleted the fetch-subject-before-edit branch April 6, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants