FOUR-26340 | ”about:blank” Displays From the Preview Pane of a Manual Task Using a List Table - #1926
Open
mcraeteisha wants to merge 4 commits into
Open
FOUR-26340 | ”about:blank” Displays From the Preview Pane of a Manual Task Using a List Table#1926mcraeteisha wants to merge 4 commits into
mcraeteisha wants to merge 4 commits into
Conversation
Add null/undefined checks in openLink() and openExternalLink() methods to prevent attempting to open windows with invalid URLs. This prevents potential errors when URLs are missing or not set.
Extract user data access into a computed property to safely handle cases where ProcessMaker/Processmaker may be undefined. Add null checks throughout the component to prevent errors when user data is unavailable. Refactor dataControls object creation into a reusable emitDataControls() method to eliminate code duplication. Ensures the component gracefully handles missing user context by hiding the table and emitting an empty state.
Add unit tests for FormListTable and FormRequests components to ensure preview functionality handles edge cases gracefully, including missing URLs, missing usernames, and user preference logic for ProcessMaker vs Processmaker global objects.
screen-builder
 |
||||||||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
bugfix/FOUR-26340
|
| Run status |
|
| Run duration | 42m 52s |
| Commit |
|
| Committer | Teisha McRae |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
1
|
 |
0
|
 |
19
|
 |
0
|
 |
388
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
| Test | Artifacts | |
|---|---|---|
| Computed fields > Focuses the first field that has an error |
Test Replay
Screenshots
|
|
|
eiresendez
approved these changes
Aug 6, 2026
eiresendez
left a comment
eiresendez
left a comment
Contributor
There was a problem hiding this comment.
Working as expected! 👍
Changed currentUser() to merge properties from both window.Processmaker?.user and window.ProcessMaker?.user, with ProcessMaker taking precedence. This ensures properties from both sources are available instead of completely overriding one with the other. Updated corresponding test to verify merge behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ticket: FOUR-26340
When a manual task used a display screen with a List Table configured for cases/requests, opening the task from the modeler preview and clicking the cases navigation control opened a blank
about:blankpage.Root cause: preview set
window.Processmakermetadata but notuser, whileform-requests.vuereadProcessmaker.user.usernameduringmounted(). That threw beforedataControlswere emitted, soform-list-table.vuecalledwindow.open(undefined)→about:blank.Solution
tasks.preview) so List Table / cases screens can resolveProcessMaker.user/Processmaker.user.dataControlswithurl: "/cases", and guard external-link opens when no URL is available.How To Test
tests/Feature/TasksTest.php --filter testPreviewBootstrapsCurrentUserForListTableFormListTablePreview.spec.js/cases(notabout:blank).Code Review Checklist