Fix goal progress verification#1759
Draft
Rohith31-WD wants to merge 8 commits into
Draft
Conversation
Implemented `outside click` and `Escape key` handling for improved sheet dismissal UX and accessibility.
…e-handling Implement close functionality for DailyBreakdownSheet
The for loop that was setting up route mocks (lines 176-183) was executing at module load time instead of during test setup. This caused Playwright to try to execute page.route() outside of a test context, triggering the error 'test.beforeEach() to be called here'. Moving the loop inside the beforeEach hook ensures all route setup happens at the correct time during test initialization.
|
@Rohith31-WD is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitsandprs)Root cause
The PATCH endpoint validated that
currentwas numeric and within target bounds, but it trusted the client as the source of truth for goals whose progress should come from GitHub activity.Validation
npm exec -- tsc --noEmitnpm exec -- vitest run test/goals-patch-progress.test.tscould not start in this sandbox because the local runner's esbuild subprocess was blocked withspawn EPERM.Fixes #1753