feat: add shared app navigation (#1330)#1331
Conversation
|
@mittalsonal is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Maintainer label request: if this looks good, please add the GSSoC labels including gssoc:approved and the appropriate difficulty/type labels so it counts correctly on the platform. Thanks! |
|
Verification note:\n- git diff --check\n\nI also attempted local type-check verification, but this checkout does not currently have a runnable TypeScript compiler installed: |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
Thanks @mittalsonal for the AppNavbar! The implementation looks solid — smooth navigation with section anchors, mobile menu, and session-aware rendering. Unfortunately there's a merge conflict now (base branch was modified by many recent merges). Please rebase onto main and we can get this in! |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
This PR has 4 merge conflicts with current main. Please rebase onto current main and resolve the conflicts before this can be merged.
Summary
Testing
git diff --checknpm run type-check(blocked locally because this checkout does not currently have a runnable TypeScript compiler installed:tscis not available in PATH and the project dependencies are not installed on this machine)