Skip to content

feat: add shared app navigation (#1330)#1331

Open
mittalsonal wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
mittalsonal:feat-app-navbar-1330-clean
Open

feat: add shared app navigation (#1330)#1331
mittalsonal wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
mittalsonal:feat-app-navbar-1330-clean

Conversation

@mittalsonal
Copy link
Copy Markdown
Contributor

Summary

  • add a shared sticky responsive navbar at the app-shell level for both signed-out and signed-in users
  • expose dashboard section anchors for Streaks, Pull Requests, and Goals so the new nav links go to real sections
  • wire landing page feature/open-source section anchors into the shared navigation

Testing

  • git diff --check
  • npm run type-check (blocked locally because this checkout does not currently have a runnable TypeScript compiler installed: tsc is not available in PATH and the project dependencies are not installed on this machine)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@mittalsonal is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mittalsonal
Copy link
Copy Markdown
Contributor Author

Maintainer label request: if this looks good, please add the GSSoC labels including gssoc:approved and the appropriate difficulty/type labels so it counts correctly on the platform. Thanks!

@mittalsonal
Copy link
Copy Markdown
Contributor Author

Verification note:\n- git diff --check\n\nI also attempted local type-check verification, but this checkout does not currently have a runnable TypeScript compiler installed:
pm run type-check fails because sc is unavailable and the project dependencies are not installed on this machine. I kept the PR scope narrow and avoided overstating verification.

@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Thanks @mittalsonal for the AppNavbar! The implementation looks solid — smooth navigation with section anchors, mobile menu, and session-aware rendering. Unfortunately there's a merge conflict now (base branch was modified by many recent merges). Please rebase onto main and we can get this in!

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has 4 merge conflicts with current main. Please rebase onto current main and resolve the conflicts before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:feature GSSoC type bonus: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants