Skip to content

fix: cap GitLab contribution pagination (#1247)#1326

Merged
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
mittalsonal:fix-gitlab-page-cap-1247
May 28, 2026
Merged

fix: cap GitLab contribution pagination (#1247)#1326
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
mittalsonal:fix-gitlab-page-cap-1247

Conversation

@mittalsonal
Copy link
Copy Markdown
Contributor

Description\n- add a GitLab pagination safety cap in etchGitLabContributions()\n- stop malformed or repeated x-next-page values from keeping the request alive indefinitely\n- align the GitLab fetch guard with the existing bounded GitHub pagination pattern in the same route\n\n## Related Issue\n- Closes #1247\n\n## Checklist\n- [x] one-file fix\n- [x] git diff --check passes\n- [x] change is scoped to the GitLab contributions pagination loop only\n\n## Pillar\n- Open Source\n

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@mittalsonal is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels May 27, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@mittalsonal
Copy link
Copy Markdown
Contributor Author

Kind request for GSSoC labels when reviewed: gssoc:approved, one level:* label, and ype:bug if it fits the repo’s scoring rubric. Thanks!

@mittalsonal
Copy link
Copy Markdown
Contributor Author

Verification completed locally:

  • git diff --check

This PR intentionally keeps the change small and limited to the GitLab contributions pagination guard in src/app/api/metrics/contributions/route.ts.

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 28, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder merged commit 228adf1 into Priyanshu-byte-coder:main May 28, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Infinite loop risk in GitLab contributions fetch when x-next-page header is malformed

2 participants