Open
Conversation
Owner
|
Thanks for your contribution. I took a look at the pure-rust version. It looks to me like there is no automated way to upgrade to incoming changes from the upstream repository. Is that correct? |
Author
|
That seems to be correct, and of course there is no guarantee that it will be upgraded. LLVM and clang are required to run C2Rust, which is more than C/C++ development requirements. A bot or something similar which transpiles the upstream repo might be required. |
Owner
|
I think I will rather keep the C version. But thank you for your
contribution.
…On Mon, 2 Mar 2020, 16:32 Hikaru Terazono, ***@***.***> wrote:
That seems to be correct, and of course there is no guarantee that it will
be upgraded.
LLVM and clang are required to run C2Rust, which is more than C/C++
development requirements. A bot or something similar which transpiles the
upstream repo might be required.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AALME5X3LXKDSU64JQ2NPK3RFO7OFA5CNFSM4KZYUVHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPQQ2Q#issuecomment-593430634>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALME5QMMK6F4T6VUXQXZPDRFO7OFANCNFSM4KZYUVHA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables to build
rust-sampleratewithout a C compiler and CMake, etc... using https://github.com/RamiHg/rust-libsamplerate , a transpiled version oflibsamplerate. This might helps to use this crate on some platforms (e.g. Windows/MSVC).