langsmith#1413
Open
kcoopermiller wants to merge 5 commits into
Open
Conversation
ApprovabilityVerdict: Needs human review This PR adds LangSmith tracing integration and introduces a new tool call tracking mechanism that changes how metrics are calculated. The new runtime behavior and feature addition warrant human review. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Add LangSmith tracing and navigation tool call logging to the Wikispeedia environment
run_idderived fromtrajectory_id,run_name, metadata, tags) intoagent.ainvokeand stores the run ID on state.click_linkandgo_backinvocation (name + validity) intostate['navigation_tool_calls']via a newrecord_navigation_tool_callhelper.count_tool_callsandinvalid_link_rateto prefer the state log over completion transcripts, preventing double-counting and enabling metrics when completion is empty.LANGSMITH_API_KEYcheck at environment load time whenLANGSMITH_TRACING=true.verifiersdependency to>=0.1.15.dev7in pyproject.toml.Macroscope summarized 0f58011.
Note
Medium Risk
Medium risk because it changes how the harness invokes Deep Agents (always passing a LangGraph/LangSmith config with derived
run_id) and alters metric computation by introducing state-based navigation tool logging, which can affect evaluation outputs.Overview
Adds LangSmith/LangGraph tracing support to the Wikispeedia Deep Agents harness by passing a structured
ainvokeconfig(stablerun_idderived fromtrajectory_id,run_name,thread_id, metadata, tags, and optionalrecursion_limit) and storingstate['langsmith_run_id']; whenLANGSMITH_TRACING=true, the environment now requiresLANGSMITH_API_KEY.Introduces explicit navigation tool-call logging (
navigation_tool_calls) forclick_link/go_backand updatestotal_tool_callsandinvalid_link_rateto prefer this log (and to avoid double-counting nav tools from completion when present), with new/updated tests and README guidance; bumps the env’sverifiersdependency.Reviewed by Cursor Bugbot for commit 0f58011. Bugbot is set up for automated code reviews on this repo. Configure here.