Normalize eval enable_thinking sampling args#682
Open
peter941221 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6281eeb. Configure here.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6281eeb0dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
Users currently follow the documented --sampling-args '{"enable_thinking": false}' form and hit AsyncCompletions.create() got an unexpected keyword argument 'enable_thinking' during local eval runs. Hosted and training paths already model enable_thinking as a first-class sampling control, so the local eval bridge should preserve that user-facing contract.
Testing
Note
Low Risk
CLI-only sampling-arg normalization and short-lived temp config files; behavior is additive for users who already pass nested
extra_body, with regression tests.Overview
Local
prime eval runnow accepts top-levelenable_thinkingin--sampling-argsJSON and in eval TOMLsampling_args, rewriting it toextra_body.chat_template_kwargs.enable_thinkingbefore verifiers runs so inference no longer rejects an unknown keyword.CLI passthrough rewrites every
--sampling-argsoccurrence; config-driven runs write a temporary TOML when needed and delete it in afinallyblock. Tests cover CLI rewrite (including multiple flags), config rewrite, and temp-file cleanup on failure.Reviewed by Cursor Bugbot for commit 3576156. Bugbot is set up for automated code reviews on this repo. Configure here.