Skip to content

ENG-3697: Improve eval sample upload progress#670

Open
d42me wants to merge 2 commits into
mainfrom
improvement/improve-upload-speed-and
Open

ENG-3697: Improve eval sample upload progress#670
d42me wants to merge 2 commits into
mainfrom
improvement/improve-upload-speed-and

Conversation

@d42me
Copy link
Copy Markdown
Contributor

@d42me d42me commented May 19, 2026

Adds eval sample upload progress reporting and reuses HTTP clients across batch uploads for faster prime eval push.


Note

Medium Risk
Touches the eval sample upload path (sync+async) and changes concurrency/network behavior by reusing a single httpx client across batches; regressions would impact reliability/throughput of push_samples and prime eval push.

Overview
Adds optional progress_callback support to EvalsClient.push_samples and AsyncEvalsClient.push_samples, reporting skipped samples and per-batch upload counts.

Refactors sample uploads to reuse a single httpx.Client / httpx.AsyncClient per push (shared headers via _samples_upload_headers) instead of creating a new client per batch, and updates prime eval push to show a Rich progress bar when running in a terminal.

Extends tests to validate progress reporting, auth header propagation, and that only one HTTP client instance is created during batch uploads.

Reviewed by Cursor Bugbot for commit 7274992. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cdd868bcf4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/prime-evals/tests/test_evals.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cdd868b. Configure here.

Comment thread packages/prime/src/prime_cli/commands/evals.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants