ENG-3697: Improve eval sample upload progress#670
Open
d42me wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdd868bcf4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdd868b. Configure here.
willccbb
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds eval sample upload progress reporting and reuses HTTP clients across batch uploads for faster prime eval push.
Note
Medium Risk
Touches the eval sample upload path (sync+async) and changes concurrency/network behavior by reusing a single
httpxclient across batches; regressions would impact reliability/throughput ofpush_samplesandprime eval push.Overview
Adds optional
progress_callbacksupport toEvalsClient.push_samplesandAsyncEvalsClient.push_samples, reporting skipped samples and per-batch upload counts.Refactors sample uploads to reuse a single
httpx.Client/httpx.AsyncClientper push (shared headers via_samples_upload_headers) instead of creating a new client per batch, and updatesprime eval pushto show a Rich progress bar when running in a terminal.Extends tests to validate progress reporting, auth header propagation, and that only one HTTP client instance is created during batch uploads.
Reviewed by Cursor Bugbot for commit 7274992. Bugbot is set up for automated code reviews on this repo. Configure here.