Skip to content

ENG-2736 - Remove Sandbox Unresponsive#337

Merged
DamianB-BitFlipper merged 9 commits intomainfrom
improvement/prime-sandboxes-enhancements
Jan 30, 2026
Merged

ENG-2736 - Remove Sandbox Unresponsive#337
DamianB-BitFlipper merged 9 commits intomainfrom
improvement/prime-sandboxes-enhancements

Conversation

@DamianB-BitFlipper
Copy link
Copy Markdown
Contributor

@DamianB-BitFlipper DamianB-BitFlipper commented Jan 27, 2026

The way that the prime cli handles "unresponsive" is not accurate. It is simply a timeout. Remove the concept of "unresponsive", and treat it as a timeout. If unresponsive sandboxes are an issue, the way to detect them would be with a liveliness checks and heartbeats.


Note

Medium Risk
Changes exception types and timeout behavior in the sandbox command execution path, which may affect downstream error handling/retries despite being a small, targeted change.

Overview
Removes the SandboxUnresponsiveError concept from prime-sandboxes. Gateway command timeouts now consistently raise CommandTimeoutError (unless the sandbox is known to be TERMINATED/ERROR/TIMEOUT, in which case _raise_not_running_error is used), and the SDK version is bumped to 0.2.13.

Also tweaks gateway command timeout handling to use effective_timeout + 2 seconds to avoid prematurely killing near-deadline commands, plus a handful of CLI formatting-only cleanups (string wrapping/whitespace) in RL and env-var/metadata utilities.

Written by Cursor Bugbot for commit 6d6e03b. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3027b44635

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/prime-sandboxes/src/prime_sandboxes/sandbox.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread packages/prime-sandboxes/src/prime_sandboxes/sandbox.py Outdated
@DamianB-BitFlipper DamianB-BitFlipper merged commit 65b0418 into main Jan 30, 2026
11 checks passed
@DamianB-BitFlipper DamianB-BitFlipper deleted the improvement/prime-sandboxes-enhancements branch January 30, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants