-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix: Added Batch delete support for flow runs #20099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
hi @saifxyzyz - thanks for the PR, i think we'd need to clean up the static analysis failures and add test coverage for this change: https://docs.prefect.io/contribute/dev-contribute let me know if you have any trouble with this! |
|
Hey @zzstoatzz , I've taken care of the static analysis failure and added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @saifxyzyz — thanks for the PR and for addressing the earlier feedback
one behavior change I’m a little concerned about: flow-run delete now appears to exit 0 even when some/all requested IDs fail. that’s a departure from existing CLI delete semantics (single delete exits non‑zero when not found; bulk delete ops elsewhere tend to abort on failure). i’d suggest keeping the best‑effort deletes but returning a non‑zero exit code if any deletions fail (while still printing the per‑ID summary), preserving scriptability without losing the new UX. if you’re good with that direction, we should update the tests accordingly.
related UX nit: for the single‑ID case, it could still show the ID in the confirmation prompt.
|
on it |
|
PTAL @zzstoatzz I've made the requested changes |
This PR adds batch delete functionality to the cli
partially closes #19904
Checklist
<link to issue>"