You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2018. It is now read-only.
There are two calls to Test-DscEventLogStatus from inside the module which should be updated to pass in the new ComputerName parameter, and we should probably also have a Credential parameter as well.
(The old code appears to have a bug; Test-DscEventLogStatus was always checking a local event log, instead of making use of the script-scope computer / credential variables. One of the many things that can shoot you in the foot when using global variables instead of parameters.)
Personally I hate global variables and would much rather see them excised from this script. However that's a bigger PR and will need more validation/testing that I'm not done writing. Also not sure you guys are interested in removing them when it doesn't really get us much.
I have updated the PR with some code to pass credentials as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking up my commits into separate PRs without any white space changes. Should be easier to review. 👍