Update-PSResource: Include local-copy prerelease string when deciding update applicability#1954
Open
sean-r-williams wants to merge 1 commit intoPowerShell:masterfrom
Conversation
…cope determination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR updates
Microsoft.PowerShell.PSResourceGet.Cmdlets.UpdatePSResourceto consider a locally-installed resource's prerelease string when comparing against the repository's available versions.Fixes #1953.
PR Context
Currently,
Update-PSResourceonly considers the locally-installed resource's version component from thePSResourceInfo.Versionfield, of typeSystem.Version. This struct doesn't include prerelease strings -PSResourceInfo.Prereleasecontains those.This means that if I have:
1.0.1-pre1.0.1...then
Update-PSResourcewill mistakenly mark the locally-installed version as "up to date".JiraPS, which recently released
2.15.0(having previously released2.15.0-alpha1in 2024, falls into this bucket.This behavior needs a test. Publishing a test module to Gallery with a prerelease, then normal-release version (i.e.
1.0.1-preand1.0.1) would be enough to test this behavior.If someone from the Gallery team can publish a test module, I'm happy to contribute a test to
test\UpdatePSResourceTests\UpdatePSResourceV2.Tests.ps1as part of this PR.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.