win_psDscAdapter.psm1: Retry to import module again if CommandNotFoundException is thrown#1575
Open
ricmestre wants to merge 3 commits into
Open
win_psDscAdapter.psm1: Retry to import module again if CommandNotFoundException is thrown#1575ricmestre wants to merge 3 commits into
ricmestre wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds error handling around module import/type resolution in the PowerShell DSC adapter to reduce failures when resolving a type from a module.
Changes:
- Wrapped the
Import-Module+ module-scoped execution in atry/catch. - Added special-case retry logic when a
CommandNotFoundExceptionis encountered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes an issue if trying to import a module and it throws a
CommandNotFoundException, e.g. when the module contains aScriptsToProcessdirective.PR Context
When trying to enumerate the resources from module
Microsoft365Dsc, which uses the adapterMicrosoft.Windows/WindowsPowerShell, it throws an error because this module contains aScriptsToProcessdirective and the functionGetTypeInstanceFromModule, fromwin_psDscAdapter.psm1, cannot cope with it because aCommandNotFoundExceptionwill be thrown . This PR fixes this by retrying to import the module once again a second time, only if the exception thrown isCommandNotFoundException, which will work as advised by @Gijsreyn.This should fix the issue #1574 I raised earlier.