Pgm/feature/custom json formatter - #1501
Conversation
mgovers
added
dependencies
| REPO_PATH = Path(__file__).parent.parent.resolve() | ||
| EXCLUDE = [ | ||
| re.compile(rf"{REPO_PATH}/docs/.*"), | ||
| re.compile(rf"{REPO_PATH}/package-lock\.json"), | ||
| re.compile(rf"{REPO_PATH}/\.vscode/.*"), | ||
| re.compile(rf"{REPO_PATH}/\.devcontainer/.*"), | ||
| re.compile(rf"{REPO_PATH}/tests/data/.*/input\.json"), | ||
| re.compile(rf"{REPO_PATH}/tests/data/.*/.*_output.*\.json"), | ||
| re.compile(rf"{REPO_PATH}/tests/data/.*/update_batch\.json"), | ||
| re.compile(rf"{REPO_PATH}/tests/unit/deprecated/data/."), | ||
| ] |
There was a problem hiding this comment.
we need this, or there will be some ugly error-prone repeated code between the code quality workflow and this repo
|
@mgovers I like to idea to get rid of npm. One alternative came into my mind to a custom JSON formatter: Biome has standalone binaries (it’s written in Rust). Unfortunately, this PR to publish Biome as Python package is currently not progressing biomejs/biome#8818 In summary I guess a custom JSON formatter - like your drafted one - might be the best solution (until there is a Python package for Biome). |
Hi @kornerc, Thank you for the input. We really appreciate it, especially after the great in-depth investigation you have done so far. 🤞 fingers crossed that that PR for biome will be published soon... |
ea9de81 to
881e110
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> actually format json Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> update script to exclude some Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> cleanup Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> minor Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> exclude uv.lock, en/decode with utf-8-sig Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> fix ruff Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> re-add markdownlint-cli Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Refresh lock and linter dependencies Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Apply suggestions from code review Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Co-authored-by: Martijn Govers <martygovers@hotmail.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com> minor Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
680e9f0 to
2489dd7
Compare
|
2 participants
In light of recent events, we are aiming to reduce our amount of dependencies - in particular the
npmones. Unfortunately, that means we need to revert some of the changes in #1256 in favor of small custom scripts.Relates to #1499