Skip to content

Fix/irrelevant buffer owning dataset#1340

Open
TonyXiang8787 wants to merge 13 commits intomainfrom
fix/irrelevant-buffer-owning-dataset
Open

Fix/irrelevant buffer owning dataset#1340
TonyXiang8787 wants to merge 13 commits intomainfrom
fix/irrelevant-buffer-owning-dataset

Conversation

@TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Mar 23, 2026

Fixes #1339

Also with some refactor in enums in validation test.

@TonyXiang8787
use enum in validation test than strings
666dde4 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
move get_output_type
c64cc27 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix a bug on read-after-free
80017ce 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
irrelevant component
56ca944 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787 TonyXiang8787 added the bug Something isn't working label Mar 23, 2026
@TonyXiang8787 TonyXiang8787 self-assigned this Mar 23, 2026
@TonyXiang8787
fix sonar cloud
db5a8a4 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
figueroa1395
figueroa1395 reviewed Mar 23, 2026
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final remark, can you add a unit test with an input dataset with faults and then create an output dataset for state estimation based on it? Additionally another one, but for an input dataset with some sensors and and output dataset for short circuit calculations.

@figueroa1395 figueroa1395 mentioned this pull request Mar 23, 2026
Open
@figueroa1395
Merge branch 'main' into fix/irrelevant-buffer-owning-dataset
47a4499
@figueroa1395
unit tests
ab322c9 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
sonar and clang tidy
3a5d1e7 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@nitbharambe
Copy link
Member

nitbharambe commented Mar 25, 2026

@figueroa1395 done with the review.

@figueroa1395
resolve comments: add missing components
a7c6152 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
improve tests
09be44e 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
only give faults special treatment
0ff8f0d 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@nitbharambe
Copy link
Member

nitbharambe commented Mar 25, 2026

Ok LGTM.
09be44e and 0ff8f0d related discussion is ongoing and maybe we follow up with a new PR. The fault component related bug gets resolved in this PR.

nitbharambe
nitbharambe previously approved these changes Mar 25, 2026
View reviewed changes
@figueroa1395
final implementation
b3c8f52 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
Copy link
Member

figueroa1395 commented Mar 25, 2026

09be44e and 0ff8f0d related discussion is ongoing and maybe we follow up with a new PR. The fault component related bug gets resolved in this PR.

This discussion and alternative implementation started because of a separate bug that is now described in #1342. This new bug is to be treated in a different PR and hence the issue was created.

For this reason, I reverted to the original implementation. The added tests are now complete.

nitbharambe
nitbharambe previously approved these changes Mar 25, 2026
View reviewed changes
@figueroa1395
format and clang tidy
1a85cbf 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395 figueroa1395 enabled auto-merge March 25, 2026 15:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@nitbharambe nitbharambe nitbharambe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@TonyXiang8787 TonyXiang8787

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] CPP API Owning dataset creates irrelevant buffers for a given calculation type

3 participants

@TonyXiang8787 @nitbharambe @figueroa1395